[PATCH] gdb: testsuite: Support displaced stepping on LoongArch

[PATCH] gdb: testsuite: Support displaced stepping on LoongArch

[Tiezhu Yang]

When execute the following command on LoongArch:

  make check-gdb TESTS="gdb.base/async-shell.exp"

we can see the following messages in gdb/testsuite/gdb.sum:

  UNSUPPORTED: gdb.base/async-shell.exp: displaced stepping

modify support_displaced_stepping to support displaced stepping
on LoongArch.

With this patch:

  PASS: gdb.base/async-shell.exp: run &
  PASS: gdb.base/async-shell.exp: shell echo foo
  PASS: gdb.base/async-shell.exp: interrupt
  PASS: gdb.base/async-shell.exp: process stopped

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 gdb/testsuite/lib/gdb.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 47cb2b2..47c1200 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3182,7 +3182,7 @@ proc support_displaced_stepping {} {
     if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"]
 	 || [istarget "arm*-*-linux*"] || [istarget "powerpc-*-linux*"]
 	 || [istarget "powerpc64-*-linux*"] || [istarget "s390*-*-*"]
-	 || [istarget "aarch64*-*-linux*"] } {
+	 || [istarget "aarch64*-*-linux*"] || [istarget "loongarch*-*-linux*"] } {
 	return 1
     }
 
-- 
2.1.0

Re: [PATCH] gdb: testsuite: Support displaced stepping on LoongArch

[Tom Tromey]

> When execute the following command on LoongArch:
>   make check-gdb TESTS="gdb.base/async-shell.exp"
> we can see the following messages in gdb/testsuite/gdb.sum:
>   UNSUPPORTED: gdb.base/async-shell.exp: displaced stepping
> modify support_displaced_stepping to support displaced stepping
> on LoongArch.

How does this affect the other tests that use support_displaced_stepping?

Anyway, this is ok if they pass.
If some of them still fail then it may be better to wait.

thank you,
Tom

Re: [PATCH] gdb: testsuite: Support displaced stepping on LoongArch

[Tiezhu Yang]

On 05/16/2022 11:18 PM, Tom Tromey wrote:
>> When execute the following command on LoongArch:
>>   make check-gdb TESTS="gdb.base/async-shell.exp"
>> we can see the following messages in gdb/testsuite/gdb.sum:
>>   UNSUPPORTED: gdb.base/async-shell.exp: displaced stepping
>> modify support_displaced_stepping to support displaced stepping
>> on LoongArch.
>
> How does this affect the other tests that use support_displaced_stepping?
>
> Anyway, this is ok if they pass.
> If some of them still fail then it may be better to wait.
>
> thank you,
> Tom
>

Hi Tom,

Thanks for your reply.

I did the following tests that use support_displaced_stepping
with this patch on LoongArch, there is no failed testcases.

loongson@linux:~/gdb.git$ grep -r support_displaced_stepping 
gdb/testsuite/gdb.*
gdb/testsuite/gdb.arch/disp-step-insn-reloc.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.base/step-over-no-symbols.exp:    if { $displaced != 
"off" && ![support_displaced_stepping] } {
gdb/testsuite/gdb.base/moribund-step.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.base/async-shell.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.base/inferior-died.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.base/step-over-syscall.exp:        if {$displaced == 
"on" && ![support_displaced_stepping]} {
gdb/testsuite/gdb.mi/mi-watch-nonstop.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.mi/mi-ns-stale-regcache.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.mi/mi-nonstop.exp:if { ![support_displaced_stepping] } {
gdb/testsuite/gdb.mi/mi-nsmoribund.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.mi/mi-nsintrall.exp:if { ![support_displaced_stepping] 
} {
gdb/testsuite/gdb.mi/mi-nsthrexec.exp:if { ![support_displaced_stepping] 
} {
gdb/testsuite/gdb.mi/mi-nonstop-exit.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.multi/watchpoint-multi.exp:if 
[support_displaced_stepping] {
gdb/testsuite/gdb.python/py-evthreads.exp:if { 
![support_displaced_stepping] } {
gdb/testsuite/gdb.threads/step-over-lands-on-breakpoint.exp:    if { 
$displaced != "off" && ![support_displaced_stepping] } {
gdb/testsuite/gdb.threads/interrupt-while-step-over.exp:    if { 
${displaced-stepping} != "off" && ![support_displaced_stepping] } {
gdb/testsuite/gdb.threads/step-over-trips-on-watchpoint.exp:    if { 
$displaced != "off" && ![support_displaced_stepping] } {

If you are OK, I will push this patch with the above info in the
commit message.

Thanks,
Tiezhu

Re: [PATCH] gdb: testsuite: Support displaced stepping on LoongArch

[Tom Tromey]

>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:

> I did the following tests that use support_displaced_stepping
> with this patch on LoongArch, there is no failed testcases.

> If you are OK, I will push this patch with the above info in the
> commit message.

Sounds good to me.  Thank you.

Tom