From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Emit stopped event for DAP attach request
Date: Wed, 24 Jan 2024 08:31:13 -0700 [thread overview]
Message-ID: <87y1ceiw8u.fsf@tromey.com> (raw)
In-Reply-To: <20240117162014.2927548-1-tromey@adacore.com> (Tom Tromey's message of "Wed, 17 Jan 2024 09:20:14 -0700")
>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:
Tom> In an earlier patch, I wrote:
Tom> ... It also adds some machinery so that attach stops can be
Tom> suppressed, which I think is the right thing to do.
Tom> However, after some discussions here at AdaCore, I now believe this to
Tom> be incorrect -- while DAP says that expected "continue" events should
Tom> be suppressed, there is no corresponding language for expected "stop"
Tom> events, and indeed "stop" events explicitly mention cases like "step".
Tom> This patch arranges for the stop event to be emitted again.
I'm checking this in.
Tom
prev parent reply other threads:[~2024-01-24 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 16:20 Tom Tromey
2024-01-24 15:31 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1ceiw8u.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).