From: Tom Tromey <tom@tromey.com>
To: Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org>
Cc: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>,
Thiago Jung Bauermann <thiago.bauermann@linaro.org>,
simark@simark.ca, tom@tromey.com
Subject: Re: [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically
Date: Tue, 10 Oct 2023 13:45:59 -0600 [thread overview]
Message-ID: <87y1gatg5k.fsf@tromey.com> (raw)
In-Reply-To: <87h6n8effl.fsf@linaro.org> (Thiago Jung Bauermann via Gdb-patches's message of "Mon, 02 Oct 2023 21:07:58 -0300")
>>>>> "Thiago" == Thiago Jung Bauermann via Gdb-patches <gdb-patches@sourceware.org> writes:
>> gdb_test "ptype foo.three_ptr.all" \
>> - " = array \\(<>\\) of integer"
>> + " = array \\(1 \\.\\. 3\\) of integer"
Thiago> The new indentation level is inconsistent with the rest of the file.
Thiago> Please preserve the original indentation level.
I think gdb standardized on 4 space indent for Tcl, but some files are
still wrong here. However normally I think we'd want reindentations to
be a separate patch. Fine to do that as a prelude if it makes your task
easier.
Tom
next prev parent reply other threads:[~2023-10-10 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 22:29 [PATCH v3 0/4] Dynamic properties of pointers Abdul Basit Ijaz
2023-09-04 22:29 ` [PATCH v3 1/4] gdb, testsuite: handle icc and icpc deprecated remarks Abdul Basit Ijaz
2023-10-03 0:04 ` Thiago Jung Bauermann
2023-09-04 22:29 ` [PATCH v3 2/4] gdb, types: Resolve pointer types dynamically Abdul Basit Ijaz
2023-10-03 0:07 ` Thiago Jung Bauermann
2023-10-10 19:45 ` Tom Tromey [this message]
2024-01-03 21:06 ` Ijaz, Abdul B
2024-01-03 21:06 ` Ijaz, Abdul B
2023-10-10 19:49 ` Tom Tromey
2024-01-03 21:31 ` Ijaz, Abdul B
2023-09-04 22:29 ` [PATCH v3 3/4] gdb, intel-classic-compilers, testsuite: workaround icc/icpc/ifort pointer/reference DWARF Abdul Basit Ijaz
2023-10-03 0:09 ` Thiago Jung Bauermann
2023-10-10 19:52 ` Tom Tromey
2024-01-03 21:15 ` Ijaz, Abdul B
2023-09-04 22:29 ` [PATCH v3 4/4] gdb, testsuite, fortran: Fix sizeof intrinsic for ifort Fortran pointers Abdul Basit Ijaz
2023-10-03 0:16 ` Thiago Jung Bauermann
2023-09-27 21:11 ` [PING][PATCH v3 0/4] Dynamic properties of pointers Ijaz, Abdul B
2023-10-03 0:17 ` [PATCH " Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1gatg5k.fsf@tromey.com \
--to=tom@tromey.com \
--cc=abdul.b.ijaz@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).