RE: [PING][PATCH v3 0/4] Dynamic properties of pointers

["Ijaz, Abdul B" <abdul.b.ijaz@intel.com>]

Ping!

Thanks & Best Regards,
Abdul Basit

-----Original Message-----
From: Ijaz, Abdul B <abdul.b.ijaz@intel.com> 
Sent: Tuesday, September 5, 2023 12:30 AM
To: gdb-patches@sourceware.org
Cc: Ijaz, Abdul B <abdul.b.ijaz@intel.com>; simark@simark.ca; tom@tromey.com
Subject: [PATCH v3 0/4] Dynamic properties of pointers

From: "Ijaz, Abdul B" <abdul.b.ijaz@intel.com>

Hi!

Please find attached v3 of this series where for v2 series there is already some feedback and the main change in patch 3 review is still missing to fix 'some compiler DWARF that is wrong but we still want to support it' patch after a discussion in https://sourceware.org/pipermail/gdb-patches/2022-September/192159.html

V2 patch 2 was approved by Tom already in this discussion but there are minor changes since then:
https://sourceware.org/pipermail/gdb-patches/2023-January/195353.html

V2 can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-October/192389.html

V1 with feedback can be found here:
https://sourceware.org/pipermail/gdb-patches/2022-September/191934.html

Changes since v2:

  * Patch 1 has minor change where now test for icc versions more
  generally.

  * Patch 2:
  Patch 2 has minor change in TYPE_CODE_PTR handling and rest was already
  reviewed in V2 series for handling of DW_AT_associated attribute
  in patch 3.

  * Patch 3:
  This already has the DW_AT_associated handling from V2 series and only
  handling of reference/pointer type is improved for Intel classic compilers.

  * Patch 4: Added a comment to the change for handling of
  DW_TAG_pointer_type.

I'm looking forward to comments.

Thanks & Best Regards,
Abdul Basit

Bernhard Heckel (1):
  gdb, types: Resolve pointer types dynamically

Nils-Christian Kempke (3):
  gdb, testsuite: handle icc and icpc deprecated remarks
  gdb, intel-classic-compilers, testsuite: workaround icc/icpc/ifort
    pointer/reference DWARF
  gdb, testsuite, fortran: Fix sizeof intrinsic for ifort Fortran
    pointers

 gdb/eval.c                                    |   9 +
 gdb/gdbtypes.c                                | 101 +++++++++-
 gdb/gdbtypes.h                                |   5 +
 gdb/testsuite/gdb.cp/vla-cxx.cc               |   4 +
 gdb/testsuite/gdb.cp/vla-cxx.exp              |  15 ++
 gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp       |  16 +-
 .../icc-ifort-pointers-and-references.c       |  38 ++++
 .../icc-ifort-pointers-and-references.exp     | 169 +++++++++++++++++
 .../gdb.fortran/pointer-to-pointer.exp        |   2 +-
 gdb/testsuite/gdb.fortran/pointers.exp        | 173 ++++++++++++++++++
 gdb/testsuite/gdb.fortran/pointers.f90        |  29 +++
 gdb/testsuite/gdb.fortran/sizeof.exp          | 115 ++++++++++++
 gdb/testsuite/gdb.fortran/sizeof.f90          | 108 +++++++++++
 gdb/testsuite/lib/gdb.exp                     |  14 +-
 gdb/valprint.c                                |  40 +++-
 15 files changed, 812 insertions(+), 26 deletions(-)  create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.exp
 create mode 100644 gdb/testsuite/gdb.fortran/pointers.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90

--
2.34.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928