From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH] [gdb/build] Work around cgen odr violations
Date: Tue, 22 Aug 2023 09:54:48 -0600 [thread overview]
Message-ID: <87y1i3ul6f.fsf@tromey.com> (raw)
In-Reply-To: <d1cfdf42-8a5e-aa7d-966b-666de51b4ed3@suse.de> (Tom de Vries via Gdb-patches's message of "Mon, 21 Aug 2023 08:05:51 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
>> That was WONTFIX'd unfortunately.
Tom> Yep, unfortunate indeed.
Tom> FWIW, the rationale given there was about libopcodes being a C
Tom> library, and I also briefly considered encapsulating the use of the
Tom> *-desc.h files in a C file, and exporting a cgen-free interface from
Tom> there, to be used in C++ files, but I found that there's no longer any
Tom> real support for compiling C inside the gdb dir.
I didn't look too deeply, but it seems to me that if the types in
question are truly only used by libopcodes -- and never directly
referred to by gdb -- then this would be a -Wodr bug.
OTOH if the types have to be used by library users, then yeah, renaming
is preferable by far.
I don't know which is the case here though.
Tom
prev parent reply other threads:[~2023-08-22 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 8:38 Tom de Vries
2023-08-18 15:46 ` Tom Tromey
2023-08-21 6:05 ` Tom de Vries
2023-08-22 15:54 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1i3ul6f.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).