Re: [PATCH] [gdb/build] Work around cgen odr violations

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> When building gdb with -flto -O2, I run into:
Tom> ...
Tom> opcodes/mep-desc.h:250:14: warning: type 'cgen_operand_type' violates the \
Tom>   C++ One Definition Rule [-Wodr]
Tom>  typedef enum cgen_operand_type {

I thought... hey, the best way is probably to change cgen to emit
different names for these things.  So I tried looking at cgen.  Then I
found out I don't know how it can even be run at all.  Maybe it requires
the obsolete-and-no-longer-shipped Guile 1.8 -- it definitely barfs with
newer versions.

Tom> Fix this by making the conflicting type names unique, adding a target-specific
Tom> prefix using a define before the include:
Tom> ...
Tom>  #define cgen_operand_type <target-name>_cgen_operand_type
Tom>  #define cgen_hw_type  <target-name>_cgen_hw_type
Tom>  #include "opcodes/<target-name>-desc.h"
Tom> ...

Thanks.

Approved-By: Tom Tromey <tom@tromey.com>

Tom> A PR has been filed to take care of this in the opcodes dir instead (PR30758).

That was WONTFIX'd unfortunately.

Tom