From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org, Takashi Yano <takashi.yano@nifty.ne.jp>
Subject: Re: [PATCH] Cygwin: Fix putting inferior in foreground (fix input)
Date: Tue, 27 Feb 2024 07:13:10 -0700 [thread overview]
Message-ID: <87zfvmuhah.fsf@tromey.com> (raw)
In-Reply-To: <20240226204445.1324953-1-pedro@palves.net> (Pedro Alves's message of "Mon, 26 Feb 2024 20:44:45 +0000")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> The problem is that inflow.c:child_terminal_inferior is failing to put
Pedro> the inferior in the foreground, because we're passing down the
Pedro> inferior's Windows PID instead of the Cygwin PID to Cygwin tcsetpgrp.
Thanks. My first thought was that this should really be
target-specific, but I dug into the code and I see that this is only
called from inf_child_target -- i.e., it is. I wonder if a bunch of
that code could be moved out of inflow.c and into inf-child.c.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2024-02-27 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 20:44 Pedro Alves
2024-02-27 14:13 ` Tom Tromey [this message]
2024-02-27 14:40 ` Pedro Alves
2024-02-27 14:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zfvmuhah.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=takashi.yano@nifty.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).