Re: [PATCH] gdb: pass frames as `const frame_info_ptr &`

[Andrew Burgess <aburgess@redhat.com>]

Simon Marchi <simon.marchi@efficios.com> writes:

> On 2/20/24 06:24, Andrew Burgess wrote:
>> 
>> Thank you for this!
>> 
>> I've wanted this change since frame_info_ptr was first added, but never
>> got around to actually writing the patch.
>> 
>> I haven't looked through every line of this, but I did flick through,
>> and what I saw looks good.  I also applied the patch and did a build
>> with no issues, except...
>
> To my defense, they were there previously!  But I might as well remove
> them since I touch the lines.
>
>> 
>> ... you've introduced trailing whitespace in 5 places!  I've marked them
>> all in the patch below.
>
> When you reply in-line, can you trim the unrelevant portions of the
> patch?  It's a bit difficult to find your replies in 12k lines.

Sorry.  My client auto-hides large blocks of quoted text.  I'll try to
do better in future.

Thanks,
Andrew


>
>> 
>> I'd be happy to see this merged.
>> 
>> Approved-By: Andrew Burgess <aburgess@redhat.com>
>
> Thanks, will push with the spaces removed.
>
> Simon