From: Simon Marchi <simon.marchi@efficios.com>
To: Andrew Burgess <aburgess@redhat.com>,
Simon Marchi <simon.marchi@polymtl.ca>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: pass frames as `const frame_info_ptr &`
Date: Tue, 20 Feb 2024 10:44:51 -0500 [thread overview]
Message-ID: <5bdbc615-ad3c-46e0-ac4b-bc6b1ea0a556@efficios.com> (raw)
In-Reply-To: <87frxn5qg4.fsf@redhat.com>
On 2/20/24 06:24, Andrew Burgess wrote:
>
> Thank you for this!
>
> I've wanted this change since frame_info_ptr was first added, but never
> got around to actually writing the patch.
>
> I haven't looked through every line of this, but I did flick through,
> and what I saw looks good. I also applied the patch and did a build
> with no issues, except...
To my defense, they were there previously! But I might as well remove
them since I touch the lines.
>
> ... you've introduced trailing whitespace in 5 places! I've marked them
> all in the patch below.
When you reply in-line, can you trim the unrelevant portions of the
patch? It's a bit difficult to find your replies in 12k lines.
>
> I'd be happy to see this merged.
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks, will push with the spaces removed.
Simon
next prev parent reply other threads:[~2024-02-20 15:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 18:07 Simon Marchi
2024-02-20 11:24 ` Andrew Burgess
2024-02-20 15:44 ` Simon Marchi [this message]
2024-02-21 14:13 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdbc615-ad3c-46e0-ac4b-bc6b1ea0a556@efficios.com \
--to=simon.marchi@efficios.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).