From: Tom Tromey <tom@tromey.com>
To: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom de Vries <tdevries@suse.de>
Subject: Re: [PATCH v3 1/5] [gdb/symtab] Fix data race on index_cache::m_enabled
Date: Sun, 06 Aug 2023 15:01:54 -0600 [thread overview]
Message-ID: <87zg337um5.fsf@tromey.com> (raw)
In-Reply-To: <20230804000329.21405-2-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Fri, 4 Aug 2023 02:03:25 +0200")
>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> - = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd] ()
Tom> + = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd,
Tom> + ctx = std::move (ctx)] ()
I just noticed this. Move captures are part of C++14, not C++11.
It doesn't look too expensive to just copy the index_cache_store_context
instead.
Tom
next prev parent reply other threads:[~2023-08-06 21:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 0:03 [PATCH v3 0/5] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom de Vries
2023-08-04 0:03 ` [PATCH v3 1/5] [gdb/symtab] Fix data race on index_cache::m_enabled Tom de Vries
2023-08-06 21:01 ` Tom Tromey [this message]
2023-08-07 0:01 ` Tom de Vries
2023-08-04 0:03 ` [PATCH v3 2/5] [gdb/symtab] Fix data race on bfd::{cacheable,format} Tom de Vries
2023-08-04 0:03 ` [PATCH v3 3/5] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued,is_debug_type} Tom de Vries
2023-08-04 0:03 ` [PATCH v3 4/5] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in,is_debug_type} Tom de Vries
2023-08-04 0:03 ` [PATCH v3 5/5] [gdb/testsuite] Extend gdb.base/index-cache.exp Tom de Vries
2023-08-04 17:03 ` [PATCH v3 0/5] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg337um5.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).