public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>,
	Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3 1/5] [gdb/symtab] Fix data race on index_cache::m_enabled
Date: Mon, 7 Aug 2023 02:01:51 +0200	[thread overview]
Message-ID: <d77b2980-ccaf-5ff1-02e3-cb11a0dd042a@suse.de> (raw)
In-Reply-To: <87zg337um5.fsf@tromey.com>

On 8/6/23 23:01, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> -    = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd] ()
> Tom> +    = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd,
> Tom> +						   ctx = std::move (ctx)] ()
> 
> I just noticed this.  Move captures are part of C++14, not C++11.
> 
> It doesn't look too expensive to just copy the index_cache_store_context
> instead.

Thanks for letting me know, I"ve submitted this patch ( 
https://sourceware.org/pipermail/gdb-patches/2023-August/201386.html ).

Thanks,
- Tom


  reply	other threads:[~2023-08-07  0:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-04  0:03 [PATCH v3 0/5] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom de Vries
2023-08-04  0:03 ` [PATCH v3 1/5] [gdb/symtab] Fix data race on index_cache::m_enabled Tom de Vries
2023-08-06 21:01   ` Tom Tromey
2023-08-07  0:01     ` Tom de Vries [this message]
2023-08-04  0:03 ` [PATCH v3 2/5] [gdb/symtab] Fix data race on bfd::{cacheable,format} Tom de Vries
2023-08-04  0:03 ` [PATCH v3 3/5] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued,is_debug_type} Tom de Vries
2023-08-04  0:03 ` [PATCH v3 4/5] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in,is_debug_type} Tom de Vries
2023-08-04  0:03 ` [PATCH v3 5/5] [gdb/testsuite] Extend gdb.base/index-cache.exp Tom de Vries
2023-08-04 17:03 ` [PATCH v3 0/5] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d77b2980-ccaf-5ff1-02e3-cb11a0dd042a@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).