Re: [PUSHED] gdb/testsuite: compile gdb.linespec/cp-completion-aliases.exp as C++

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> On 5/2/23 12:54, Andrew Burgess via Gdb-patches wrote:
>> Noticed in passing that the prepare_for_testing call in
>> gdb.linespec/cp-completion-aliases.exp does not pass the 'c++' flag,
>> despite this being a C++ test.
>> 
>> I guess, as the source file has the '.cc' extension, all the compilers
>> are doing the right thing anyway -- the source file uses templates, so
>> is definitely being compiled as C++.
>> 
>> I noticed this when I tried to set CXX_FOR_TARGET (but not
>> CC_FOR_TARGET) and spotted that this script was still using the C
>> compiler.
>> 
>> Fixed in this commit by adding the 'c++' flag for prepare_for_testing.
>
> Hi,
>
> this is an instance of 
> https://sourceware.org/bugzilla/show_bug.cgi?id=30380 .
>
> I already had this fixed in a branch, but hadn't had time to submit.
>
> FWIW, it's the top commit of 
> https://github.com/vries/gdb/commits/testsuite/old-gcc .

Sorry for duplicating this work.  I ran into this case while working on
some other patch and I didn't want to have to carry around such a
trivial local patch.

Hope this didn't cause you any serious problems.

Thanks,
Andrew