public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Bounds check access to Ada task state names
Date: Wed, 30 Nov 2022 08:45:23 -0700	[thread overview]
Message-ID: <87zgc8mooc.fsf@tromey.com> (raw)
In-Reply-To: <20221116210011.198094-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 16 Nov 2022 14:00:11 -0700")

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> While looking into Ada tasking a little, I noticed that no bounds
Tom> checking is done on accesses to the Ada task state names arrays.  This
Tom> isn't a problem currently, but if the runtime ever added numbers -- or
Tom> if there was some kind of runtime corruption -- it could cause a gdb
Tom> crash.

Tom> This patch adds range checking.  It also adds a missing _() call when
Tom> printing from the 'task_states' array.

I'm checking this in now.

Tom

      reply	other threads:[~2022-11-30 15:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 21:00 Tom Tromey
2022-11-30 15:45 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgc8mooc.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).