public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix two minor flake8 issues
Date: Fri, 23 Feb 2024 14:33:08 -0500	[thread overview]
Message-ID: <89af7e7a-f792-40a4-a6c2-89902ffc5380@simark.ca> (raw)
In-Reply-To: <20240223190145.3629627-1-tromey@adacore.com>



On 2024-02-23 14:01, Tom Tromey wrote:
> flake8 pointed out some extra whitespace around ':' in some Python
> code.

If we change these, black is going to immediately want to revert them.

We need to tell flake8 to ignore these formatting warnings, since the
formatting is all taken care of.  See:

https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html#flake8

I propose to just add this in gdb/.flake8 or gdb/setup.cfg, as the page
suggests:

[flake8]
max-line-length = 88
extend-ignore = E203,E701

Simon

  reply	other threads:[~2024-02-23 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-23 19:01 Tom Tromey
2024-02-23 19:33 ` Simon Marchi [this message]
2024-02-23 19:39   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89af7e7a-f792-40a4-a6c2-89902ffc5380@simark.ca \
    --to=simark@simark.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).