From: Tom Tromey <tromey@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix two minor flake8 issues
Date: Fri, 23 Feb 2024 12:39:58 -0700 [thread overview]
Message-ID: <87frxjx94h.fsf@tromey.com> (raw)
In-Reply-To: <89af7e7a-f792-40a4-a6c2-89902ffc5380@simark.ca> (Simon Marchi's message of "Fri, 23 Feb 2024 14:33:08 -0500")
>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
Simon> If we change these, black is going to immediately want to revert them.
lol I forgot about this.
Simon> I propose to just add this in gdb/.flake8 or gdb/setup.cfg, as the page
Simon> suggests:
Simon> [flake8]
Simon> max-line-length = 88
Simon> extend-ignore = E203,E701
Please do.
Internally I see we use:
# See
# https://github.com/psf/black/blob/master/docs/compatible_configs.md#black-compatible-configurations
# to understand the max-line-length and extend-ignore settings.
max-line-length = 88
extend-ignore: E203, W503, B906, B907
I don't remember what these other ones are about.
Tom
prev parent reply other threads:[~2024-02-23 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 19:01 Tom Tromey
2024-02-23 19:33 ` Simon Marchi
2024-02-23 19:39 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frxjx94h.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).