From: Pedro Alves <pedro@palves.net>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Remove one use of struct buffer
Date: Fri, 16 Dec 2022 13:09:05 +0000 [thread overview]
Message-ID: <89bc07a5-59a4-272f-f30e-0fd5e3fe3ccd@palves.net> (raw)
In-Reply-To: <20221216060148.1261366-1-simon.marchi@polymtl.ca>
On 2022-12-16 6:01 a.m., Simon Marchi via Gdb-patches wrote:
> Tom mentioned the goal of getting rid of struct buffer, and that made me
> remember I had these patches laying around.
>
Yeah, IIRC, struct buffer existed avoid obstack in gdbserver I think because
back then gdbserver didn't link with libiberty. There used to be a obstack_xml_printf
function too, which was eliminated too since. Glad to see it all go.
> Simon Marchi (2):
> gdbsupport: add string_xml_appendf
> gdb: convert linux-osdata.c from buffer to std::string
LGTM.
("There is not change" -> "There is no change" in patch 2's commit log.)
>
> gdb/nat/linux-osdata.c | 287 +++++++++++++++++++++-------------------
> gdbsupport/xml-utils.cc | 105 +++++++++++++++
> gdbsupport/xml-utils.h | 10 ++
> 3 files changed, 263 insertions(+), 139 deletions(-)
>
>
> base-commit: de75275fe54c5536c8238f0f3f88bb7ac2222942
>
next prev parent reply other threads:[~2022-12-16 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 6:01 Simon Marchi
2022-12-16 6:01 ` [PATCH 1/2] gdbsupport: add string_xml_appendf Simon Marchi
2022-12-16 6:01 ` [PATCH 2/2] gdb: convert linux-osdata.c from buffer to std::string Simon Marchi
2022-12-16 13:09 ` Pedro Alves [this message]
2022-12-16 13:32 ` [PATCH 0/2] Remove one use of struct buffer Simon Marchi
2022-12-16 15:04 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89bc07a5-59a4-272f-f30e-0fd5e3fe3ccd@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).