From: Simon Marchi <simark@simark.ca>
To: "Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] Add more flexibility to inferior call
Date: Fri, 24 Mar 2023 09:38:14 -0400 [thread overview]
Message-ID: <8a75f1cd-a09a-2e34-f294-89d253d4d46a@simark.ca> (raw)
In-Reply-To: <DM6PR11MB445738C62A12B506E486ABE9E4879@DM6PR11MB4457.namprd11.prod.outlook.com>
On 3/23/23 07:34, Bouhaouel, Mohamed wrote:
> Hi Simon,
>
> Thanks for your feedback. These patches are pre-requisite for an Intel architecture
> that has not been yet up-streamed. Waiting for the architecture to be introduced
> first is likely more logical, although, such flexibility might be useful for
> other new architectures.
>
> Should I submit a new version of those patches while considering your comments
> or wait to post all together?
I think it's better to post it with the first architecture that uses it.
It helps illustrate what the method is for and how it works. But also,
if your port never ends up upstream for whatever reason, it doesn't make
sense to have those methods with no users.
Simon
next prev parent reply other threads:[~2023-03-24 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 17:13 Mohamed Bouhaouel
2023-03-22 17:13 ` [PATCH 1/2] gdb, gdbarch, infcall: Add value_arg_coerce method to gdbarch Mohamed Bouhaouel
2023-03-22 19:18 ` Simon Marchi
2023-03-22 17:13 ` [PATCH 2/2] gdb, gdbarch, infcall: Add reserve_stack_space " Mohamed Bouhaouel
2023-03-22 19:16 ` [PATCH 0/2] Add more flexibility to inferior call Simon Marchi
2023-03-23 11:34 ` Bouhaouel, Mohamed
2023-03-24 13:38 ` Simon Marchi [this message]
2023-03-24 14:10 ` Bouhaouel, Mohamed
2023-03-24 14:12 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a75f1cd-a09a-2e34-f294-89d253d4d46a@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=mohamed.bouhaouel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).