Re: [PATCH v4] gdb: Enable early init of thread pool size

[Richard Bunt <richard.bunt@linaro.org>]

On 05/12/2023 07:56, Tom de Vries wrote:
> On 11/27/23 21:23, Tom Tromey wrote:
>>>>>>> "Richard" == Richard Bunt <richard.bunt@linaro.org> writes:
>>
>> Richard> Updates in v4.
>> Richard> Clamped the default number of worker threads to eight. I'm ok 
>> with this as GDB
>> Richard> can always be configured to use a higher number of work 
>> threads if the use case
>> Richard> demands it.
>>
>> I think these are fine.  Thank you for doing this.
>> Approved-By: Tom Tromey <tom@tromey.com>
> 
> I think this caused:
> ...
> FAIL: gdb.gdb/index-file.exp: maintenance show worker-threads
> ERROR: tcl error sourcing 
> /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp.
> ERROR: invalid bareword "UNKNOWN"
> in expression "UNKNOWN / 2";
> should be "$UNKNOWN" or "{UNKNOWN}" or "UNKNOWN(...)" or ...
>      (parsing expression "UNKNOWN / 2")
>      invoked from within
> "expr $worker_threads / 2"
>      invoked from within
> "if { $worker_threads > 1 } {
>      # Start GDB, but don't load a file yet.
>      clean_restart
> 
>      # Adjust the number of threads to use.
>      set reduced..."
>      (file "/data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" 
> line 127)
>      invoked from within
> "source /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp"
>      ("uplevel" body line 1)
>      invoked from within
> "uplevel #0 source 
> /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp"
>      invoked from within
> "catch "uplevel #0 source $test_file_name""
> ...
> 
> Thanks,
> - Tom

Thanks for flagging.

I'm looking in to the issue.

Rich.