public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] gdb: make lookup_selected_frame static
@ 2022-11-07 18:45 Simon Marchi
  2022-11-07 18:55 ` Simon Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: Simon Marchi @ 2022-11-07 18:45 UTC (permalink / raw)
  To: gdb-patches; +Cc: Simon Marchi

From: Simon Marchi <simon.marchi@efficios.com>

Change-Id: Ide2749a34333110c7f0112b25852c78cace0d2b4
---
 gdb/frame.c | 8 ++++++--
 gdb/frame.h | 7 -------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/gdb/frame.c b/gdb/frame.c
index 5cf9186e43d7..14f9668ce00c 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1707,9 +1707,13 @@ restore_selected_frame (frame_id frame_id, int frame_level)
   selected_frame = nullptr;
 }
 
-/* See frame.h.  */
+/* Lookup the frame_info object for the selected frame FRAME_ID /
+   FRAME_LEVEL and cache the result.
 
-void
+   If FRAME_LEVEL > 0 and the originally selected frame isn't found,
+   warn and select the innermost (current) frame.  */
+
+static void
 lookup_selected_frame (struct frame_id a_frame_id, int frame_level)
 {
   frame_info_ptr frame = NULL;
diff --git a/gdb/frame.h b/gdb/frame.h
index f61ea63c290b..0a142ad2fc48 100644
--- a/gdb/frame.h
+++ b/gdb/frame.h
@@ -264,13 +264,6 @@ extern void save_selected_frame (frame_id *frame_id, int *frame_level)
 extern void restore_selected_frame (frame_id frame_id, int frame_level)
   noexcept;
 
-/* Lookup the frame_info object for the selected frame FRAME_ID /
-   FRAME_LEVEL and cache the result.
-
-   If FRAME_LEVEL > 0 and the originally selected frame isn't found,
-   warn and select the innermost (current) frame.  */
-extern void lookup_selected_frame (frame_id frame_id, int frame_level);
-
 /* Given a FRAME, return the next (more inner, younger) or previous
    (more outer, older) frame.  */
 extern frame_info_ptr get_prev_frame (frame_info_ptr);

base-commit: 4faede6126762a9704da4c79093cca15c15efafa
-- 
2.38.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pushed] gdb: make lookup_selected_frame static
  2022-11-07 18:45 [pushed] gdb: make lookup_selected_frame static Simon Marchi
@ 2022-11-07 18:55 ` Simon Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2022-11-07 18:55 UTC (permalink / raw)
  To: Simon Marchi, gdb-patches

On 11/7/22 13:45, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@efficios.com>
> 
> Change-Id: Ide2749a34333110c7f0112b25852c78cace0d2b4
> ---
>  gdb/frame.c | 8 ++++++--
>  gdb/frame.h | 7 -------
>  2 files changed, 6 insertions(+), 9 deletions(-)

Heh, sorry, I forgot to write the commit message before pushing.  Anyhow, it's quite
obvious, this function is only used locally in frame.c.

Simon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-11-07 18:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 18:45 [pushed] gdb: make lookup_selected_frame static Simon Marchi
2022-11-07 18:55 ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).