From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH v2] gdb: make thread_info::m_thread_fsm a std::unique_ptr
Date: Fri, 28 Jan 2022 07:38:33 -0500 [thread overview]
Message-ID: <8cd45f68-74bf-32d9-7955-fcf8c72366b3@polymtl.ca> (raw)
In-Reply-To: <20220128110107.38775-1-lancelot.six@amd.com>
> @@ -443,6 +444,32 @@ class thread_info : public refcounted_object,
> m_suspend.stop_reason = reason;
> }
>
> + /* Get the FSM associated with the thread. */
> +
> + struct thread_fsm *get_thread_fsm () const
Style comment: I don't know if this is a consistent style, but at least
in my changes, I usually omit the "get_" prefix for the getters.
> + {
> + return m_thread_fsm.get ();
> + }
> +
> + /* Get the owning reference to the FSM associated with the thread.
> +
> + After a call to this method, "get_thread_fsm == null". */
null -> nullptr.
LGTM with those changed.
Simon
next prev parent reply other threads:[~2022-01-28 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:01 Lancelot SIX
2022-01-28 12:38 ` Simon Marchi [this message]
2022-01-28 14:55 ` Six, Lancelot
2022-02-07 11:15 ` Six, Lancelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cd45f68-74bf-32d9-7955-fcf8c72366b3@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).