From: "Six, Lancelot" <Lancelot.Six@amd.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH v2] gdb: make thread_info::m_thread_fsm a std::unique_ptr
Date: Fri, 28 Jan 2022 14:55:40 +0000 [thread overview]
Message-ID: <PH0PR12MB5452F69D472103EF1AFB40DA83229@PH0PR12MB5452.namprd12.prod.outlook.com> (raw)
In-Reply-To: <8cd45f68-74bf-32d9-7955-fcf8c72366b3@polymtl.ca>
[AMD Official Use Only]
> > @@ -443,6 +444,32 @@ class thread_info : public refcounted_object,
> > m_suspend.stop_reason = reason;
> > }
> >
> > + /* Get the FSM associated with the thread. */
> > +
> > + struct thread_fsm *get_thread_fsm () const
>
> Style comment: I don't know if this is a consistent style, but at least in my changes, I usually omit the "get_" prefix > for the getters.
> > + After a call to this method, "get_thread_fsm == null". */
>
> null -> nullptr.
>
> LGTM with those changed.
>
> Simon
Hi,
I have applied both of those changes locally. I'll give it a bit more time in case anyone has more comments to it.
Thanks,
Lancelot.
next prev parent reply other threads:[~2022-01-28 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 11:01 Lancelot SIX
2022-01-28 12:38 ` Simon Marchi
2022-01-28 14:55 ` Six, Lancelot [this message]
2022-02-07 11:15 ` Six, Lancelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR12MB5452F69D472103EF1AFB40DA83229@PH0PR12MB5452.namprd12.prod.outlook.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).