Re: [PATCH] Fix bad interaction between element limit and repeated values (BZ#24331).

[Keith Seitz <keiths@redhat.com>]

Hi,

On 5/7/23 18:22, Paul Pluzhnikov via Gdb-patches wrote:
> Currently
> 
>    print -elements=3 -- "AAAAAA"
> 
> prints complete string, which is not what the user asked for.
> 
> Fix two buggy tests exposed by the fix, and add a new test.

Thank you for the patch. I just have one small ask.

> diff --git a/gdb/valprint.c b/gdb/valprint.c
> index b05d90dd26b..b770c93d805 100644
> --- a/gdb/valprint.c
> +++ b/gdb/valprint.c
> @@ -2363,16 +2363,19 @@ print_converted_chars_to_obstack (struct obstack *obstack,
>   				  const std::vector<converted_character> &chars,
>   				  int quote_char, int width,
>   				  enum bfd_endian byte_order,
> -				  const struct value_print_options *options)
> +				  const struct value_print_options *options,
> +				  int *finished)

The comment preceding this function explains the meaning of all of its
arguments. Please add `finished', too.

>   {
> -  unsigned int idx;
> +  unsigned int idx, num_elements;
>     const converted_character *elem;
>     enum {START, SINGLE, REPEAT, INCOMPLETE, FINISH} state, last;
>     gdb_wchar_t wide_quote_char = gdb_btowc (quote_char);
>     bool need_escape = false;
> +  const int print_max = options->print_max_chars > 0
> +      ? options->print_max_chars : options->print_max;
>   
>     /* Set the start state.  */
> -  idx = 0;
> +  idx = num_elements = 0;
>     last = state = START;
>     elem = NULL;
>   

Otherwise LGTM.

Reviewed-by: Keith Seitz <keiths@redhat.com>

Keith