From: Andrew Burgess <aburgess@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>, gdb-patches@sourceware.org
Cc: Keith Seitz <keiths@redhat.com>,
Paul Pluzhnikov <ppluzhnikov@google.com>
Subject: Re: [PATCH] Update comments for the gdb/24331 fix.
Date: Tue, 16 May 2023 11:55:59 +0100 [thread overview]
Message-ID: <87zg64a6kg.fsf@redhat.com> (raw)
In-Reply-To: <20230515151300.3188497-1-ppluzhnikov@google.com>
Paul Pluzhnikov <ppluzhnikov@google.com> writes:
> On Mon, May 15, 2023 at 2:43 AM Andrew Burgess <aburgess@redhat.com> wrote:
>>
>> It's fine to reference the bug, but could you expand this comment to say
>> what's actually being tested, e.g.
>
> Sorry, I've already committed previous patch.
> Ok to commit this one?
LGTM.
Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
>
> Thanks,
>
> ---
> gdb/testsuite/gdb.base/printcmds.exp | 5 ++++-
> gdb/testsuite/gdb.python/py-format-string.exp | 2 --
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/printcmds.exp b/gdb/testsuite/gdb.base/printcmds.exp
> index f2be549f2a5..2506f745f20 100644
> --- a/gdb/testsuite/gdb.base/printcmds.exp
> +++ b/gdb/testsuite/gdb.base/printcmds.exp
> @@ -1077,7 +1077,10 @@ proc test_repeat_bytes {} {
> }
> }
>
> -# Test for BZ#24331
> +# Test that 'set elements' correctly limits the number of characters
> +# printed from a string when a string ends with repeated characters.
> +# This is gdb/24331
> +
> proc test_repeat_bytes_limit {} {
> gdb_test "print -elem 3 -- \"AAAAA\"" "= \"AAA\"..."
> gdb_test "print -char 3 -elem 10 -- \"AAAAA\"" "= \"AAA\"..."
> diff --git a/gdb/testsuite/gdb.python/py-format-string.exp b/gdb/testsuite/gdb.python/py-format-string.exp
> index 2a011ebd45a..55a37766bff 100644
> --- a/gdb/testsuite/gdb.python/py-format-string.exp
> +++ b/gdb/testsuite/gdb.python/py-format-string.exp
> @@ -745,8 +745,6 @@ proc test_max_string_one { setting unlimited } {
> "${default_pointer_regexp} \"hel\"..."
> check_format_string "a_binary_string" $opts \
> "${default_pointer_regexp} \"hel\"..."
> - # This will print four characters instead of three, see
> - # <https://sourceware.org/bugzilla/show_bug.cgi?id=24331>.
> check_format_string "a_binary_string_array" $opts \
> "\"hel\"..."
> check_format_string "a_big_string" $opts \
> --
> 2.40.1.606.ga4b1b128d6-goog
prev parent reply other threads:[~2023-05-16 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 1:22 [PATCH] Fix bad interaction between element limit and repeated values (BZ#24331) Paul Pluzhnikov
2023-05-13 17:30 ` Keith Seitz
2023-05-15 9:43 ` Andrew Burgess
2023-05-15 15:13 ` [PATCH] Update comments for the gdb/24331 fix Paul Pluzhnikov
2023-05-16 10:55 ` Andrew Burgess [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zg64a6kg.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).