From: Tom de Vries <tdevries@suse.de>
To: Andreas Schwab <schwab@suse.de>,
Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [RFC] [gdb] Stop on undetermined longjmp target during next
Date: Thu, 8 Dec 2022 14:33:20 +0100 [thread overview]
Message-ID: <90e29d7d-eec8-98ac-6df3-7add583f6c75@suse.de> (raw)
In-Reply-To: <mvmilimumr0.fsf@suse.de>
On 12/8/22 13:02, Andreas Schwab wrote:
> On Dez 08 2022, Tom de Vries via Gdb-patches wrote:
>
>> diff --git a/gdb/infrun.c b/gdb/infrun.c
>> index c67458b30b6..51bc72dae5f 100644
>> --- a/gdb/infrun.c
>> +++ b/gdb/infrun.c
>> @@ -6650,7 +6650,8 @@ process_event_stop_test (struct execution_control_state *ecs)
>> {
>> infrun_debug_printf ("BPSTAT_WHAT_SET_LONGJMP_RESUME "
>> "(!gdbarch_get_longjmp_target)");
>> - keep_going (ecs);
>> + warning (_("GDB can't determine the longjmp target"));
>
> It's quite unusual to talk about yourself in the third person.
>
I suppose it is.
It's not unusual though, I can find quite a few examples in the gdb sources.
I think that stressing that the warning comes from gdb is not a bad
idea, because warnings might also be generated by inferiors.
Thanks,
- Tom
next prev parent reply other threads:[~2022-12-08 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-08 11:31 Tom de Vries
2022-12-08 12:02 ` Andreas Schwab
2022-12-08 13:33 ` Tom de Vries [this message]
2022-12-15 21:31 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90e29d7d-eec8-98ac-6df3-7add583f6c75@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=schwab@suse.de \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).