Re: [PATCH v2] gdb/gcore: interrupt all threads before generating the corefile

[Pedro Alves <pedro@palves.net>]

Hi Lancelot,

On 2022-10-17 2:43 p.m., Lancelot SIX via Gdb-patches wrote:

> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/gcore-nonstop.exp
> @@ -0,0 +1,73 @@
> +# Copyright 2022 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +
> +# This testcase checks that when in non-stop mode with some threads running
> +# the gcore command can interrupt all threads, generate a core dump and
> +# restart threads as required.
> +
> +standard_testfile
> +
> +if { [prepare_for_testing "failed to prepare" \
> +	${testfile} ${srcfile} {threads debug}] } {
> +    return
> +}
> +
> +gdb_test_no_output "set non-stop on"

Let's please make this testcase work with --target_board=native-extended-gdbserver.

As is, it will most certainly fail because this is too late to enable non-stop mode.

Most tests address this by appending the set command to GDBFLAGS, like this from
gdb.threads/interrupt-while-step-over.exp:

    save_vars { GDBFLAGS } {
        append GDBFLAGS " -ex \"set non-stop on\""
        clean_restart $binfile
    }

Otherwise LGTM.

Pedro Alves