public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH v2] gdb/gcore: interrupt all threads before generating the corefile
Date: Wed, 9 Nov 2022 18:53:43 +0000	[thread overview]
Message-ID: <e542207c-4a37-f14f-609e-f1f59ec09f45@amd.com> (raw)
In-Reply-To: <91a96187-48fd-4823-6b82-dbf8e8f70bce@palves.net>

> Let's please make this testcase work with --target_board=native-extended-gdbserver.
> 
> As is, it will most certainly fail because this is too late to enable non-stop mode.
> 
> Most tests address this by appending the set command to GDBFLAGS, like this from
> gdb.threads/interrupt-while-step-over.exp:
> 
>      save_vars { GDBFLAGS } {
>          append GDBFLAGS " -ex \"set non-stop on\""
>          clean_restart $binfile
>      }
Hi,

Thanks for catching this.

I'll change this, rebase, retest and send a v3.

Best,
Lancelot.

      reply	other threads:[~2022-11-09 18:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17 13:43 Lancelot SIX
2022-11-01 14:44 ` [PING][PATCH " Lancelot SIX
2022-11-08 14:01 ` [PATCH " Pedro Alves
2022-11-09 18:53   ` Lancelot SIX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e542207c-4a37-f14f-609e-f1f59ec09f45@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).