From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH v2 1/2] gdb/buildsym: Line record use a record flag
Date: Thu, 31 Mar 2022 11:04:41 +0100 [thread overview]
Message-ID: <91b4b5fd-b05b-73ad-f3f3-8c662e7544eb@palves.net> (raw)
In-Reply-To: <20220330093458.148497-2-lancelot.six@amd.com>
On more thing I noticed while looking at patch #2:
On 2022-03-30 10:34, Lancelot SIX via Gdb-patches wrote:
> +/* Flags associated with a linetable entry. */
> +
> +enum linetable_entry_flag : unsigned
> +{
> + LEF_IS_STMT = 1 << 1,
Could you add a comment documenting what each flag means, please. Here for IS_STMT, I guess
you can just copy the comment from linetable_entry:
/* True if this PC is a good location to place a breakpoint for LINE. */
unsigned is_stmt : 1;
> +};
> +DEF_ENUM_FLAGS_TYPE (enum linetable_entry_flag, linetable_entry_flags);
> +
next prev parent reply other threads:[~2022-03-31 10:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 9:34 [PATCH v2 0/2] Add support for DWARF's prologue_end flag in line-table Lancelot SIX
2022-03-30 9:34 ` [PATCH v2 1/2] gdb/buildsym: Line record use a record flag Lancelot SIX
2022-03-31 9:57 ` Pedro Alves
2022-03-31 10:18 ` Pedro Alves
2022-03-31 10:04 ` Pedro Alves [this message]
2022-03-30 9:34 ` [PATCH v2 2/2] gdb: Add support for DW_LNS_set_prologue_end in line-table Lancelot SIX
2022-03-30 12:26 ` Eli Zaretskii
2022-03-30 12:54 ` Lancelot SIX
2022-03-31 10:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91b4b5fd-b05b-73ad-f3f3-8c662e7544eb@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).