From: Tom de Vries <tdevries@suse.de>
To: Carl Love <cel@us.ibm.com>, gdb-patches@sourceware.org
Cc: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
Tom Tromey <tom@tromey.com>,
Will Schmidt <will_schmidt@vnet.ibm.com>
Subject: Re: [pushed] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le
Date: Tue, 29 Nov 2022 08:24:51 +0100 [thread overview]
Message-ID: <927c5ef2-d53d-6024-829e-b46eacc5368d@suse.de> (raw)
In-Reply-To: <79e6af35f8f7731809833267bdbeb5f1a80a5672.camel@us.ibm.com>
On 11/29/22 00:01, Carl Love wrote:
> Tom:
>
> On Mon, 2022-11-28 at 23:09 +0100, Tom de Vries wrote:
>> Yes, that also works for me as well as $bkptno_num_re which I
>> mentioned
>>> in my previous email work for me. I guess my preference would be
>>> $bkptno_num_re if it also works for you.
>>
>> That one doesn't work. As mentioned in the comment, it attempts to
>> match:
>> ...
>> # A regular expression that matches a breakpoint hit with a
>> breakpoint
>>
>> # having several code locations.
>>
>> set bkptno_num_re "$decimal\\.$decimal"
>> ...
>> in other words, "1.1" and in my case there's only one code location,
>> in
>> other words, "1".
>
> Yea, right. So I think we are down to the following patch that works
> on my Power 10 with no regressions. It sounds like this one works for
> you as well.
>
LGTM.
Approved-By: Tom de Vries <tdevries@suse.de>
Thanks,
- Tom
next prev parent reply other threads:[~2022-11-29 7:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 16:21 Tom de Vries
2022-11-28 17:45 ` Carl Love
2022-11-28 18:08 ` Tom de Vries
2022-11-28 19:55 ` Carl Love
2022-11-28 20:46 ` Tom de Vries
2022-11-28 21:07 ` Carl Love
2022-11-28 21:31 ` Tom de Vries
2022-11-28 21:44 ` Carl Love
2022-11-28 22:09 ` Tom de Vries
2022-11-28 23:01 ` Carl Love
2022-11-29 7:24 ` Tom de Vries [this message]
2022-11-28 21:33 ` Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=927c5ef2-d53d-6024-829e-b46eacc5368d@suse.de \
--to=tdevries@suse.de \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=will_schmidt@vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).