Re: [pushed] [gdb/testsuite] Fix gdb.ada/out_of_line_in_inlined.exp for ppc64le

[Tom de Vries <tdevries@suse.de>]

On 11/28/22 22:07, Carl Love wrote:
> Tom:
> 
> On Mon, 2022-11-28 at 21:46 +0100, Tom de Vries wrote:
>>>    I made the change   $decimal\\.$decimal?  and that seemed
>>> to work on my system.  I tried the test on my X86 box but it is not
>>> supported.  Looks like the system doesn't have the ada compiler
>>> installed.
>>>
>>> Can you verify that the change works on your system and if the
>>> patch
>>> looks ok.  Thanks.
>>>
>>
>> It doesn't work, as expected, because the output is:
>> ...
>> Breakpoint 1, foo_o224_021.child1.child2 (s=...) at
>> /home/vries/gdb_versions/devel/binutils-
>> gdb.git/gdb/testsuite/gdb.ada/out_of_line_in_inlined/foo_o224_021.adb
>> :24^M
>> ...
>> and $decimal\\.$decimal? does not match "1".
> 
> If I use the original suggestion, here is the patch I ran:
> 
> diff --git a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
> index 621b04e179b..54c55bc6f7e 100644
> --- a/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
> +++ b/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp
> @@ -34,7 +34,7 @@ foreach_with_prefix scenario {all minimal} {
>   
>       gdb_run_cmd
>       gdb_test "" \
> -	"Breakpoint $decimal, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \
> +	"Breakpoint $decimal(\\.$decimal)?, ($hex in )?foo_o224_021\\.child1\\.child2 \\(s=\\.\\.\\.\\).*" \
>   	"run to foo_o224_021.child1.child2"
>   
>       set opt_addr_in "($hex in)?"
> 
> then I run the test I get:
> 
> make check RUNTESTFLAGS='GDB=/home/carll/bin/gdb  gdb.ada/out_of_line_in_inlined.exp   ' > out
> WARNING: Couldn't find the global config file.
> WARNING: Couldn't find tool init file
> WARNING: Couldn't find the global config file.
> WARNING: Couldn't find tool init file
> WARNING: Couldn't find the global config file.
> WARNING: Couldn't find tool init file
> WARNING: Couldn't find the global config file.
> WARNING: No tool specified
> WARNING: Couldn't find the global config file.
> ERROR: tcl error sourcing /home/carll/GDB/build-test/gdb/testsuite/../../../binutils-gdb-test/gdb/testsuite/gdb.ada/out_of_line_in_inlined.exp.
> ERROR: tcl error code TCL LOOKUP VARNAME decimal
> ERROR: can't read "decimal(\.[0-9]+)": variable isn't array

Ah I see, yes the $var($index) is tcl syntax for accessing an array element.

So, this should work: ${decimal}(\\.$decimal)?

Thanks,
- Tom