From: John Baldwin <jhb@FreeBSD.org>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove some alloca uses
Date: Sat, 20 Apr 2024 13:27:19 -0700 [thread overview]
Message-ID: <9301b16a-06c5-4f4d-b706-257936a1e18d@FreeBSD.org> (raw)
In-Reply-To: <20240417225228.1789947-1-tom@tromey.com>
On 4/17/24 3:52 PM, Tom Tromey wrote:
> A few spots (mostly in the parsers) use alloca to ensure that a string
> is terminated before passing it to a printf-like function (mostly
> 'error'). However, this isn't needed as the "%.*s" format can be used
> instead.
>
> This patch makes this change.
>
> In one spot the alloca is dead code and is simply removed.
Approved-By: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
next prev parent reply other threads:[~2024-04-20 20:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 22:52 Tom Tromey
2024-04-20 20:27 ` John Baldwin [this message]
2024-04-22 9:41 ` [PUSHED] gdb: fix unknown variable typo in c-exp.y Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9301b16a-06c5-4f4d-b706-257936a1e18d@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).