Re: [PATCH] gdb: cast return value of std::unique_ptr::release to void

[Simon Marchi <simark@simark.ca>]

> Normally I think we should work to get rid of .release() calls.
> However this one looks like a pain, probably why it is already there.
> And, your patch doesn't make anything worse in this regard.  So as much
> as I hate cast to void I think it's ok.

Same feeling here.  It's not pretty, but the (void) doesn't change
anything in what we're doing.

I wanted to change cmd_list_element in the past to have "doc_holder" and
"name_holder" fields, both of which would be
gdb::unique_xmalloc_ptr<char>.  They would be set if the
cmd_list_element owns the memory for doc and name, and would make the
management automatic.  But I'm afraid that people will say "but it makes
cmd_list_element larger for nothing", so I never sent it.  But if you
think it's worth it, I can do that.


> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, will push.

Simon