Re: [PATCH] gdb: cast return value of std::unique_ptr::release to void

[Tom Tromey <tom@tromey.com>]

Simon> I wanted to change cmd_list_element in the past to have "doc_holder" and
Simon> "name_holder" fields, both of which would be
Simon> gdb::unique_xmalloc_ptr<char>.  They would be set if the
Simon> cmd_list_element owns the memory for doc and name, and would make the
Simon> management automatic.  But I'm afraid that people will say "but it makes
Simon> cmd_list_element larger for nothing", so I never sent it.  But if you
Simon> think it's worth it, I can do that.

I am not worried about the space savings here.  It doesn't seem so bad
to have a bit of manual management in this code, but at the same time,
it wouldn't be a huge amount of memory, and if it makes things clearer,
then it seems great.

Stove-piping the unique ptr through all this code seems like a pain,
though.

I've sometimes wondered if we want a either-owns-or-is-constant-string
smart pointer type.  But it seems maybe hard to make this safe to use,
as in it may be easy to construct one improperly.

Tom