* [PATCH] Update python-helper.exp for type allocation changes
@ 2023-03-20 16:19 Tom Tromey
2023-03-20 17:08 ` Tom de Vries
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-03-20 16:19 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
The type allocation changes introduced a failure in python-helper.exp
that I did not notice. The bug is that, with these patches,
arch-allocated integer types have a TYPE_SPECIFIC_INT object attached.
This patch updates the test to allow this.
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30253
---
gdb/testsuite/gdb.gdb/python-helper.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp
index dbd78cbcf78..a58e3b601df 100644
--- a/gdb/testsuite/gdb.gdb/python-helper.exp
+++ b/gdb/testsuite/gdb.gdb/python-helper.exp
@@ -145,7 +145,7 @@ proc test_python_helper {} {
" flags = \[^\r\n\]+," \
" owner = $hex \\(gdbarch\\)," \
" target_type = 0x0," \
- " type_specific_field = TYPE_SPECIFIC_NONE}"]
+ " int_stuff = { bit_size = $decimal, bit_offset = $decimal }}"]
gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type"
# Send the continue to the outer GDB, which resumes the inner GDB,
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Update python-helper.exp for type allocation changes
2023-03-20 16:19 [PATCH] Update python-helper.exp for type allocation changes Tom Tromey
@ 2023-03-20 17:08 ` Tom de Vries
0 siblings, 0 replies; 2+ messages in thread
From: Tom de Vries @ 2023-03-20 17:08 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 3/20/23 17:19, Tom Tromey via Gdb-patches wrote:
> The type allocation changes introduced a failure in python-helper.exp
> that I did not notice. The bug is that, with these patches,
> arch-allocated integer types have a TYPE_SPECIFIC_INT object attached.
> This patch updates the test to allow this.
>
Hi,
I've applied that patch and verified that it fixes the FAIL.
LGTM.
Thanks,
- Tom
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30253
> ---
> gdb/testsuite/gdb.gdb/python-helper.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.gdb/python-helper.exp b/gdb/testsuite/gdb.gdb/python-helper.exp
> index dbd78cbcf78..a58e3b601df 100644
> --- a/gdb/testsuite/gdb.gdb/python-helper.exp
> +++ b/gdb/testsuite/gdb.gdb/python-helper.exp
> @@ -145,7 +145,7 @@ proc test_python_helper {} {
> " flags = \[^\r\n\]+," \
> " owner = $hex \\(gdbarch\\)," \
> " target_type = 0x0," \
> - " type_specific_field = TYPE_SPECIFIC_NONE}"]
> + " int_stuff = { bit_size = $decimal, bit_offset = $decimal }}"]
> gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type"
>
> # Send the continue to the outer GDB, which resumes the inner GDB,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-20 17:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-20 16:19 [PATCH] Update python-helper.exp for type allocation changes Tom Tromey
2023-03-20 17:08 ` Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).