Re: [PATCH] [gdb] Fix assert in delete_breakpoint

[Tom de Vries <tdevries@suse.de>]

On 11/15/23 12:12, Tom de Vries wrote:
> Because it's deleted twice.

Just to confirm this theory, I added this patch:
...
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index fe09dbcbeee..12a3a2260d7 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -12583,6 +12583,8 @@ void
  delete_breakpoint (struct breakpoint *bpt)
  {
    gdb_assert (bpt != NULL);
+  fprintf (stderr, "delete_breakpoint: %p\n", bpt);
+  fflush (stderr);

    /* Has this bp already been deleted?  This can happen because
       multiple lists can hold pointers to bp's.  bpstat lists are
...
and got:
...
   [infrun] handle_signal_stop: [17091.17091.0] hit its single-step 
breakpoint^M
delete_breakpoint: 0xabc756a8^M
delete_breakpoint: 0xabc756a8^M
/home/rock/gdb/src/gdb/../gdbsupport/intrusive_list.h:458: 
internal-error: erase_element: Assertion `elem_node->prev \
!= INTRUSIVE_LIST_UNLINKED_VALUE' failed.^M
...

Thanks,
- Tom