From: Tom de Vries <tdevries@suse.de>
To: Hannes Domani <ssbssa@yahoo.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4 2/2] [gdb] Fix segfault in for_each_block, part 2
Date: Tue, 28 Nov 2023 10:47:50 +0100 [thread overview]
Message-ID: <993259bc-b367-452a-a370-50588a5f0be7@suse.de> (raw)
In-Reply-To: <543290455.2684585.1699604662307@mail.yahoo.com>
On 11/10/23 09:24, Hannes Domani wrote:
> Am Freitag, 10. November 2023 um 09:08:11 MEZ hat Tom de Vries <tdevries@suse.de> Folgendes geschrieben:
>
>> --- a/gdb/s390-linux-nat.c
>> +++ b/gdb/s390-linux-nat.c
>> @@ -949,10 +949,12 @@ s390_target_wordsize (void)
>> /* Check for 64-bit inferior process. This is the case when the host is
>> 64-bit, and in addition bit 32 of the PSW mask is set. */
>> #ifdef __s390x__
>> + int tid = s390_inferior_tid ();
>> + gdb_assert (tid == 0);
>
> Did you not mean `tid != 0` here?
>
I did, thanks for spotting that.
I hadn't been able to test on s390x yet, by now I have.
Fixed in the v5 version I've pushed (
https://sourceware.org/pipermail/gdb-patches/2023-November/204569.html ).
Thanks,
- Tom
prev parent reply other threads:[~2023-11-28 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 8:09 [PATCH v4 0/2] [gdb] Fix segfault in for_each_block Tom de Vries
2023-11-10 8:09 ` [PATCH v4 1/2] [gdb] Fix segfault in for_each_block, part 1 Tom de Vries
2023-11-28 9:52 ` Tom de Vries
2023-11-10 8:09 ` [PATCH v4 2/2] [gdb] Fix segfault in for_each_block, part 2 Tom de Vries
2023-11-10 8:24 ` Hannes Domani
2023-11-28 9:47 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=993259bc-b367-452a-a370-50588a5f0be7@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=ssbssa@yahoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).