Re: [PATCH v2] [gdb/testsuite] Handle ptrace operation not permitted in can_spawn_for_attach

[Simon Marchi <simark@simark.ca>]

On 2024-05-01 04:34, Tom de Vries wrote:
> When running the testsuite on a system with kernel.yama.ptrace_scope set to 1,
> we run into attach failures.
> 
> Fix this by recognizing "ptrace: Operation not permitted" in
> can_spawn_for_attach.
> 
> Tested on aarch64-linux and x86_64-linux.

Hi Tom,

Since this patch, I see some problems in test
gdb.testsuite/gdb-caching-proc-consistency.exp with the native-gdbserver
board:

    ERROR: in testcase /home/smarchi/src/binutils-gdb/gdb/testsuite/gdb.testsuite/gdb-caching-proc-consistency.exp
    ERROR:  gdbserver does not support attach 1186109 without extended-remote
    ERROR:  tcl error code NONE
    ERROR:  tcl error info:
    gdbserver does not support attach 1186109 without extended-remote
        while executing                          
    "error "gdbserver does not support $command without extended-remote""
        (procedure "gdb_test_multiple" line 51)
        invoked from within
    "gdb_test_multiple "attach $test_pid" "can spawn for attach" {
            -re -wrap "$attaching_re\r\n.*ptrace: Operation not permitted\\." {
                # Not permitte..."
        (procedure "gdb_real__can_spawn_for_attach_1" line 27)
        invoked from within
    "gdb_real__can_spawn_for_attach_1"
        ("uplevel" body line 1)
        invoked from within
    "uplevel 2 [list $real_name {*}$args]"
        invoked from within
    "gdb_do_cache_wrap $real_name"
        ("uplevel" body line 2)
        invoked from within
    "uplevel 1 $body"                            
        invoked from within
    ...

Simon