Re: [PATCH v2] [gdb/testsuite] Handle ptrace operation not permitted in can_spawn_for_attach

[Pedro Alves <pedro@palves.net>]

On 2024-05-01 09:34, Tom de Vries wrote:

>  
> -    # Assume yes.
> -    return 1
> +    # The normal sequence to use for a runtime test like
> +    # can_spawn_for_attach_1 is:
> +    # - gdb_exit (don't use a running gdb, we don't know what state it is in),
> +    # - gdb_start (start a new gdb), and
> +    # - gdb_exit (cleanup).
> +    #
> +    # By making can_spawn_for_attach_1 a gdb_caching_proc, we make it
> +    # unpredictable which test-case will call it first, and consequently a
> +    # test-case may pass in say a full test run, but fail when run
> +    # individually, due to a can_spawn_for_attach call in location where a

"in a location", I presume.

> +    # gdb_exit (as can_spawn_for_attach_1 does) breaks things.

Otherwise,

 Approved-By: Pedro Alves <pedro@palves.net>

Thank you.