Re: [PATCH] Remove f-strings from DAP

[Paul Koning <paulkoning@comcast.net>]

> On Jun 2, 2023, at 11:45 AM, Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> 
> Kévin pointed out that gdb claims a minimum Python version of 3.2, but
> the DAP code uses f-strings, which were added in 3.6.
> 
> This patch removes the uses of f-strings from the DAP code.  I can't
> test an older version of Python, but I did confirm that this still
> works with the version I have.
> ---
> gdb/python/lib/gdb/dap/evaluate.py | 2 +-
> gdb/python/lib/gdb/dap/io.py       | 2 +-
> gdb/python/lib/gdb/dap/launch.py   | 2 +-
> gdb/python/lib/gdb/dap/state.py    | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/evaluate.py
> index fffd255417b..7c4fee4f84b 100644
> --- a/gdb/python/lib/gdb/dap/evaluate.py
> +++ b/gdb/python/lib/gdb/dap/evaluate.py
> @@ -62,7 +62,7 @@ def eval_request(*, expression, frameId=None, context="variables", **args):
>     elif context == "repl":
>         return send_gdb_with_response(lambda: _repl(expression, frameId))
>     else:
> -        raise Exception(f'unknown evaluate context "{context}"')
> +        raise Exception("unknown evaluate context " + context)

That (and the others) is not quite equivalent to what was there before.  You might do this with calls to the "format" method explicitly, as in:

+        raise Exception('unknown evaluate context "{}"'.format(context))

	paul