From: Paul Koning <paulkoning@comcast.net>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org, legouguec@adacore.com
Subject: Re: [PATCH] Remove f-strings from DAP
Date: Fri, 2 Jun 2023 14:14:18 -0400 [thread overview]
Message-ID: <D3F78FC4-96BB-474A-84D2-26DAD856A9C6@comcast.net> (raw)
In-Reply-To: <875y85vn53.fsf@tromey.com>
> On Jun 2, 2023, at 12:34 PM, Tom Tromey <tromey@adacore.com> wrote:
>
>>>>>> "Paul" == Paul Koning <paulkoning@comcast.net> writes:
>
>>> - raise Exception(f'unknown evaluate context "{context}"')
>>> + raise Exception("unknown evaluate context " + context)
>
> Paul> That (and the others) is not quite equivalent to what was there
> Paul> before.
>
> Yeah, it isn't identical, but it's the same in practice.
>
> In some spots the argument is known to be a string, and in ones where
> str() is applied, it's known to be an int. This is clearer after the
> runtime type-checking patch is applied.
>
> Tom
Ok, but at least in that line I pointed to, the output is different: the previous text quotes the value while your changed code does not.
paul
next prev parent reply other threads:[~2023-06-02 18:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 15:45 Tom Tromey
2023-06-02 15:57 ` Paul Koning
2023-06-02 16:34 ` Tom Tromey
2023-06-02 18:14 ` Paul Koning [this message]
2023-06-02 19:02 ` Tom Tromey
2023-06-12 18:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3F78FC4-96BB-474A-84D2-26DAD856A9C6@comcast.net \
--to=paulkoning@comcast.net \
--cc=gdb-patches@sourceware.org \
--cc=legouguec@adacore.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).