From: Keith Seitz <keiths@redhat.com>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] Minor expression cleanups
Date: Fri, 28 Apr 2023 09:14:06 -0700 [thread overview]
Message-ID: <9a2f5081-5655-583d-51d2-2209ebb30648@redhat.com> (raw)
In-Reply-To: <20230428-minor-expr-cleanuups-v1-0-0a634e8d5c25@adacore.com>
On 4/28/23 09:02, Tom Tromey via Gdb-patches wrote:
> While looking at some parser-related changes for DAP, I found a few
> things that could be cleaned up independently.
>
> Regression tested on x86-64 Fedora 36.
[Very] Nice cleanups. I've looked over the series, and it LGTM.
Keith
> ---
> Tom Tromey (3):
> Remove op_name
> Remove evaluate_expression
> Remove evaluate_type
>
> gdb/ada-lang.c | 4 ++--
> gdb/arc-tdep.c | 2 +-
> gdb/breakpoint.c | 2 +-
> gdb/cli/cli-script.c | 4 ++--
> gdb/darwin-nat-info.c | 2 +-
> gdb/dtrace-probe.c | 4 ++--
> gdb/eval.c | 25 ++++---------------------
> gdb/expprint.c | 41 +++++++++++++++++------------------------
> gdb/expression.h | 12 +++++++-----
> gdb/gnu-v3-abi.c | 2 +-
> gdb/linux-thread-db.c | 2 +-
> gdb/mi/mi-main.c | 6 +++---
> gdb/objc-lang.c | 4 +---
> gdb/printcmd.c | 12 ++++++------
> gdb/stack.c | 2 +-
> gdb/stap-probe.c | 2 +-
> gdb/tracepoint.c | 2 +-
> gdb/typeprint.c | 4 ++--
> gdb/value.c | 2 +-
> gdb/value.h | 11 -----------
> gdb/varobj.c | 14 +++++++-------
> 21 files changed, 62 insertions(+), 97 deletions(-)
> ---
> base-commit: 1f7f972f59470104734ec705c985ab319eb580db
> change-id: 20230428-minor-expr-cleanuups-77d8f8d15594
>
> Best regards,
next prev parent reply other threads:[~2023-04-28 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 16:02 Tom Tromey
2023-04-28 16:02 ` [PATCH 1/3] Remove op_name Tom Tromey
2023-04-28 16:02 ` [PATCH 2/3] Remove evaluate_expression Tom Tromey
2023-04-28 16:02 ` [PATCH 3/3] Remove evaluate_type Tom Tromey
2023-04-28 16:14 ` Keith Seitz [this message]
2023-05-01 17:04 ` [PATCH 0/3] Minor expression cleanups Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a2f5081-5655-583d-51d2-2209ebb30648@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).