[PING][PATCH v2] gdb/testsuite: XFAIL some gdb.base/fileio.exp

[Guinevere Larsen <blarsen@redhat.com>]

Ping!

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

On 14/08/2023 12:24, Guinevere Larsen wrote:
> Some gdb.base/fileio.exp tests expect the inferior to not have write
> access to some files. If the test is being run as root, this is never
> possible. This commit adds a way to identify if the user is root and
> xfails the tests that expect no write access.
> ---
>
> Changes for v2:
> * root_user now uses remote_exec instead of exec to see the uid of the
>    inferior
>
> ---
>   gdb/testsuite/gdb.base/fileio.exp |  9 ++++++++-
>   gdb/testsuite/lib/gdb.exp         | 11 +++++++++++
>   2 files changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.base/fileio.exp b/gdb/testsuite/gdb.base/fileio.exp
> index 33c88d064c4..e1c7a7f955e 100644
> --- a/gdb/testsuite/gdb.base/fileio.exp
> +++ b/gdb/testsuite/gdb.base/fileio.exp
> @@ -17,7 +17,6 @@
>   
>   require {!target_info exists gdb,nofileio}
>   
> -
>   standard_testfile
>   
>   if {[is_remote host]} {
> @@ -75,6 +74,10 @@ gdb_test "continue" ".*" ""
>   
>   catch "system \"chmod -f -w [standard_output_file nowrt.fileio.test]\""
>   
> +# If the user is root, we will always have write permission
> +if { [root_user] } {
> +    setup_xfail *-*
> +}
>   gdb_test continue \
>   "Continuing\\..*open 5:.*EACCES$stop_msg" \
>   "Open for write but no write permission returns EACCES"
> @@ -240,6 +243,10 @@ gdb_test continue \
>   if [ishost *cygwin*] {
>       setup_xfail "*-*-*"
>   }
> +# If the user is root, we will always have write permission
> +if { [root_user] } {
> +    setup_xfail *-*
> +}
>   gdb_test continue \
>   "Continuing\\..*unlink 2:.*EACCES$stop_msg" \
>   "Unlinking a file in a directory w/o write access returns EACCES"
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 36bf738c667..d7947e0dcf4 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -9952,5 +9952,16 @@ proc have_host_locale { locale } {
>       return [expr $idx != -1]
>   }
>   
> +# Return 1 if the test is being run as root, 0 otherwise
> +
> +gdb_caching_proc root_user {} {
> +    # ID outputs to stdout, we have to use exec to capture it here
> +    set user [remote_exec id]
> +
> +    regexp -all ".*uid=(\[0-9\]+).*" $user user uid
> +
> +    return [expr $uid == 0]
> +}
> +
>   # Always load compatibility stuff.
>   load_lib future.exp