Re: [PATCH] gdb/testsuite: XFAIL some gdb.base/fileio.exp

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Guinevere,

I am not a big fan of the idea of running the testcases as root… but I
guess this is what you have when running within a container.

> +# Return 1 if the test is being run as root, 0 otherwise
> +
> +gdb_caching_proc root_user {} {
> +    # ID outputs to stdout, we have to use exec to capture it here
> +    set user [exec id]

Shouldn't it be `[remote_exec target]` instead?  You are interested in
who will end up running the test executable, which can be different from
who runs `runtest` locally.  I am not entirely sure if it should be
`host` or `target`.  I would think `target`, but the testcase does use
`host`, which seems odd to me.

Also, what happens if the underlying filesystem is for example a NFS
mount?  I am not sure being root will change what unlink can do, but I
have not tested.  Maybe it is not worth trying to figure out all setups,
if it comes up one can always adjust the test.

Best,
Lancelot.

> +
> +    regexp -all ".*uid=(\[0-9\]+).*" $user user uid
> +
> +    return [expr $uid == 0]
> +}
> +
>  # Always load compatibility stuff.
>  load_lib future.exp
> -- 
> 2.41.0
>