* [PATCH] Fix the i386 build
@ 2020-10-01 23:05 Kamil Rytarowski
2020-10-01 23:13 ` Simon Marchi
0 siblings, 1 reply; 2+ messages in thread
From: Kamil Rytarowski @ 2020-10-01 23:05 UTC (permalink / raw)
To: gdb-patches
Remove old, no longer needed and no longer valid extern.
../../gdb/i386-nbsd-tdep.c:58:12: error: 'i386nbsd_sc_reg_offset' was declared 'extern' and later 'static' [-fpermissive]
58 | static int i386nbsd_sc_reg_offset[] =
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from ../../gdb/i386-nbsd-tdep.c:31:
../../gdb/i386-tdep.h:480:12: note: previous declaration of 'i386nbsd_sc_reg_offset'
480 | extern int i386nbsd_sc_reg_offset[];
| ^~~~~~~~~~~~~~~~~~~~~~
gdb/ChangeLog:
* i386-tdep.h (i386nbsd_sc_reg_offset): Remove.
---
gdb/ChangeLog | 4 ++++
gdb/i386-tdep.h | 1 -
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 33e5df7b224..8081081b8d0 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,7 @@
+2020-10-01 Kamil Rytarowski <n54@gmx.com>
+
+ * i386-tdep.h (i386nbsd_sc_reg_offset): Remove.
+
2020-10-01 Kamil Rytarowski <n54@gmx.com>
* i386-bsd-nat.c (_initialize_i386bsd_nat): Update.
diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
index c61ffcfb76e..5ff2eed548a 100644
--- a/gdb/i386-tdep.h
+++ b/gdb/i386-tdep.h
@@ -477,7 +477,6 @@ extern CORE_ADDR i386obsd_sigtramp_start_addr;
extern CORE_ADDR i386obsd_sigtramp_end_addr;
extern int i386fbsd4_sc_reg_offset[];
extern int i386fbsd_sc_reg_offset[];
-extern int i386nbsd_sc_reg_offset[];
extern int i386obsd_sc_reg_offset[];
extern int i386bsd_sc_reg_offset[];
--
2.28.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix the i386 build
2020-10-01 23:05 [PATCH] Fix the i386 build Kamil Rytarowski
@ 2020-10-01 23:13 ` Simon Marchi
0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-10-01 23:13 UTC (permalink / raw)
To: Kamil Rytarowski, gdb-patches
On 2020-10-01 7:05 p.m., Kamil Rytarowski wrote:
> Remove old, no longer needed and no longer valid extern.
>
> ../../gdb/i386-nbsd-tdep.c:58:12: error: 'i386nbsd_sc_reg_offset' was declared 'extern' and later 'static' [-fpermissive]
> 58 | static int i386nbsd_sc_reg_offset[] =
> | ^~~~~~~~~~~~~~~~~~~~~~
> In file included from ../../gdb/i386-nbsd-tdep.c:31:
> ../../gdb/i386-tdep.h:480:12: note: previous declaration of 'i386nbsd_sc_reg_offset'
> 480 | extern int i386nbsd_sc_reg_offset[];
> | ^~~~~~~~~~~~~~~~~~~~~~
This looks like an obvious patch to me.
Simon
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-01 23:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-01 23:05 [PATCH] Fix the i386 build Kamil Rytarowski
2020-10-01 23:13 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).