Re: [PATCH] Fix random dejagnu test abort with simulator target

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

On 4/19/24 18:30, Tom de Vries wrote:
> 
> OK, I see now.
> 
> We spawn gdb on host to spawn sleep on target.
> 
> So I get to:
> ...
> # The test-case relies on "run" from the command line, so it only works
> # with "target native", so we need host == target.
> #
> # The test-case uses "exp_pid -i $gdb_spawn_id" which doesn't work with
> # remote host, so we need build == host.
> #
> # In other words, we need build == host == target.
> require {!is_remote host} {!is_remote target}
> 
> # Check that we have "target native" as opposed to native-gdbserver etc.
> require {string equal [target_info gdb_protocol] ""}
> ...
> 
> Having said that, I'm not sure if that addresses your problem, since I don't have experience with simulator setups.
> 
> Perhaps "require isnative" is also necessary for simulators?  That proc seems to check for target triplet == build triplet, while I think we're more interested in target triplet == host triplet, but it may be a sufficient proxy.
> 

hmm...

[target_info is_simulator] is explicitly set for simulators.
see /usr/share/dejagnu/baseboards/basic-sim.exp:
set_board_info is_simulator 1

I use RUNTESTFLAGS="--target_board=multi-sim"

I tried your suggested change, and it worked for me:
--- a/gdb/testsuite/gdb.base/sigwinch-notty.exp
+++ b/gdb/testsuite/gdb.base/sigwinch-notty.exp
@@ -19,11 +19,17 @@
 
 require {!target_info exists gdb,nosignals}
 
-# The testfile relies on "run" from the command line, so only works
-# with "target native".
-if { [target_info gdb_protocol] != "" || [target_info is_simulator] != ""} {
-    return
-}
+# The test-case relies on "run" from the command line, so it only works
+# with "target native", so we need host == target.
+#
+# The test-case uses "exp_pid -i $gdb_spawn_id" which doesn't work with
+# remote host, so we need build == host.
+#
+# In other words, we need build == host == target.
+require {!is_remote host} {!is_remote target}
+
+# Check that we have "target native" as opposed to native-gdbserver etc.
+require {string equal [target_info gdb_protocol] ""}
 
 gdb_exit
 

Running /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp ...
Executing on build: rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty    (timeout = 300)
builtin_spawn -ignore SIGHUP rm -rf /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/outputs/gdb.base/sigwinch-notty^M
UNSUPPORTED: gdb.base/sigwinch-notty.exp: require failed: !is_remote target
testcase /home/ed/gnu/binutils-build-riscv-1/gdb/testsuite/../../../binutils-gdb/gdb/testsuite/gdb.base/sigwinch-notty.exp completed in 0 seconds

so that would be acceptable.


Thanks
Bernd.