[PATCH] Resolve aix-thread.c compile errors

[PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

[-- Attachment #1: Type: text/plain, Size: 751 bytes --]

Hi,

Folks using AIX face a compilation error while installing gdb.

In aix-thread.c we use ms-> value_address () to get the symbol address.
 But ms is a non pointer type for the symbol ->. So a compilation error [base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.

 This can be seen while running gmake in the binutils folder while installing.

 We must use ms.value_address () instead.

Please find attached the patch for the same. (See 0001-Resolve-aix-thread.c-compile-errors)

Kindly let me know if anything else is needed.

Kindly update the same so that AIX users can compile and install GDB without any compilation issues.

Thanks and regards,
Aditya.


[-- Attachment #2: 0001-Resolve-aix-thread.c-compile-errors.patch --]
[-- Type: application/octet-stream, Size: 1098 bytes --]

From 62b4fb6690eded79525523e9011e1938f60ed2f6 Mon Sep 17 00:00:00 2001
From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
Date: Fri, 13 May 2022 09:09:29 -0500
Subject: [PATCH] Resolve aix-thread.c compile errors

---
 gdb/aix-thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 4e41cde6694..ecd8200b692 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
 		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
 	      return PDC_FAILURE;
 	    }
-	  symbols[i].addr = ms->value_address ();
+	  symbols[i].addr = ms.value_address ();
 	}
       if (debug_aix_thread)
 	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
@@ -969,7 +969,7 @@ pd_enable (void)
   ms = lookup_minimal_symbol (stub_name, NULL, NULL);
   if (ms.minsym == NULL)
     return;
-  pd_brk_addr = ms->value_address ();
+  pd_brk_addr = ms.value_address ();
   if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
     return;
 
-- 
2.31.1

Re: [PATCH] Resolve aix-thread.c compile errors

[Joel Brobecker]

Hello,

On Fri, May 13, 2022 at 02:43:43PM +0000, Aditya Vidyadhar Kamath via Gdb-patches wrote:
> Hi,
> 
> Folks using AIX face a compilation error while installing gdb.
> 
> In aix-thread.c we use ms-> value_address () to get the symbol address.
>  But ms is a non pointer type for the symbol ->. So a compilation error [base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.
> 
>  This can be seen while running gmake in the binutils folder while installing.
> 
>  We must use ms.value_address () instead.
> 
> Please find attached the patch for the same. (See 0001-Resolve-aix-thread.c-compile-errors)
> 
> Kindly let me know if anything else is needed.
> 
> Kindly update the same so that AIX users can compile and install GDB without any compilation issues.
> 
> Thanks and regards,
> Aditya.

The change looks good to me, but it needs a proper commit message.

I think the description you give above isn't far from being sufficient,
you just need to format it a bit, and then include it in the commit
as the commit message.

We have some information about commit messages (and more) in the
following page:
https://sourceware.org/gdb/wiki/ContributionChecklist

> From 62b4fb6690eded79525523e9011e1938f60ed2f6 Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Fri, 13 May 2022 09:09:29 -0500
> Subject: [PATCH] Resolve aix-thread.c compile errors
> 
> ---
>  gdb/aix-thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
> index 4e41cde6694..ecd8200b692 100644
> --- a/gdb/aix-thread.c
> +++ b/gdb/aix-thread.c
> @@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
>  		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
>  	      return PDC_FAILURE;
>  	    }
> -	  symbols[i].addr = ms->value_address ();
> +	  symbols[i].addr = ms.value_address ();
>  	}
>        if (debug_aix_thread)
>  	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
> @@ -969,7 +969,7 @@ pd_enable (void)
>    ms = lookup_minimal_symbol (stub_name, NULL, NULL);
>    if (ms.minsym == NULL)
>      return;
> -  pd_brk_addr = ms->value_address ();
> +  pd_brk_addr = ms.value_address ();
>    if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
>      return;
>  
> -- 
> 2.31.1
> 


-- 
Joel

RE: [PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

[-- Attachment #1: Type: text/plain, Size: 3228 bytes --]

Hi,

Thank you so much for the feedback and the information on how to give a good description of commit message.

Please find attached the patch now (See: 0001-Fixed-non-pointer-type-compilation-error-in-aix-thread.c.patch)

Regards,
Aditya.

________________________________
From: Gdb-patches <gdb-patches-bounces+aditya.vidyadhar.kamath=ibm.com@sourceware.org> on behalf of Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org>
Sent: Monday, May 16, 2022 6:19 PM
To: Aditya Vidyadhar Kamath via Gdb-patches <gdb-patches@sourceware.org>
Cc: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>; Joel Brobecker <brobecker@adacore.com>
Subject: [EXTERNAL] Re: [PATCH] Resolve aix-thread.c compile errors

Hello,

On Fri, May 13, 2022 at 02:43:43PM +0000, Aditya Vidyadhar Kamath via Gdb-patches wrote:
> Hi,
>
> Folks using AIX face a compilation error while installing gdb.
>
> In aix-thread.c we use ms-> value_address () to get the symbol address.
>  But ms is a non pointer type for the symbol ->. So a compilation error [base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.
>
>  This can be seen while running gmake in the binutils folder while installing.
>
>  We must use ms.value_address () instead.
>
> Please find attached the patch for the same. (See 0001-Resolve-aix-thread.c-compile-errors)
>
> Kindly let me know if anything else is needed.
>
> Kindly update the same so that AIX users can compile and install GDB without any compilation issues.
>
> Thanks and regards,
> Aditya.

The change looks good to me, but it needs a proper commit message.

I think the description you give above isn't far from being sufficient,
you just need to format it a bit, and then include it in the commit
as the commit message.

We have some information about commit messages (and more) in the
following page:
https://sourceware.org/gdb/wiki/ContributionChecklist

> From 62b4fb6690eded79525523e9011e1938f60ed2f6 Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Fri, 13 May 2022 09:09:29 -0500
> Subject: [PATCH] Resolve aix-thread.c compile errors
>
> ---
>  gdb/aix-thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
> index 4e41cde6694..ecd8200b692 100644
> --- a/gdb/aix-thread.c
> +++ b/gdb/aix-thread.c
> @@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
>                gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
>              return PDC_FAILURE;
>            }
> -       symbols[i].addr = ms->value_address ();
> +       symbols[i].addr = ms.value_address ();
>        }
>        if (debug_aix_thread)
>        gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
> @@ -969,7 +969,7 @@ pd_enable (void)
>    ms = lookup_minimal_symbol (stub_name, NULL, NULL);
>    if (ms.minsym == NULL)
>      return;
> -  pd_brk_addr = ms->value_address ();
> +  pd_brk_addr = ms.value_address ();
>    if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
>      return;
>
> --
> 2.31.1
>


--
Joel

[-- Attachment #2: 0001-Fixed-non-pointer-type-compilation-error-in-aix-thread.c.patch --]
[-- Type: application/octet-stream, Size: 1119 bytes --]

From 75d06292c20cbe6768843090cfcb706b519f842c Mon Sep 17 00:00:00 2001
From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
Date: Tue, 17 May 2022 07:03:34 -0500
Subject: [PATCH] Fixed non-pointer type compilation error in aix-thread.c

---
 gdb/aix-thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 4e41cde6694..ecd8200b692 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
 		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
 	      return PDC_FAILURE;
 	    }
-	  symbols[i].addr = ms->value_address ();
+	  symbols[i].addr = ms.value_address ();
 	}
       if (debug_aix_thread)
 	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
@@ -969,7 +969,7 @@ pd_enable (void)
   ms = lookup_minimal_symbol (stub_name, NULL, NULL);
   if (ms.minsym == NULL)
     return;
-  pd_brk_addr = ms->value_address ();
+  pd_brk_addr = ms.value_address ();
   if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
     return;
 
-- 
2.31.1

Re: [PATCH] Resolve aix-thread.c compile errors

[Joel Brobecker]

> Thank you so much for the feedback and the information on how to give
> a good description of commit message.
> 
> Please find attached the patch now (See:
> 0001-Fixed-non-pointer-type-compilation-error-in-aix-thread.c.patch)

As far as I can tell, the patch is still missing a commit message
(other than the subject). Did you send the correct file?

> From 75d06292c20cbe6768843090cfcb706b519f842c Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Tue, 17 May 2022 07:03:34 -0500
> Subject: [PATCH] Fixed non-pointer type compilation error in aix-thread.c
> 
> ---
>  gdb/aix-thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
> index 4e41cde6694..ecd8200b692 100644
> --- a/gdb/aix-thread.c
> +++ b/gdb/aix-thread.c
> @@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
>  		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
>  	      return PDC_FAILURE;
>  	    }
> -	  symbols[i].addr = ms->value_address ();
> +	  symbols[i].addr = ms.value_address ();
>  	}
>        if (debug_aix_thread)
>  	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
> @@ -969,7 +969,7 @@ pd_enable (void)
>    ms = lookup_minimal_symbol (stub_name, NULL, NULL);
>    if (ms.minsym == NULL)
>      return;
> -  pd_brk_addr = ms->value_address ();
> +  pd_brk_addr = ms.value_address ();
>    if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
>      return;
>  
> -- 
> 2.31.1
> 


-- 
Joel

RE: [PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

[-- Attachment #1: Type: text/plain, Size: 2343 bytes --]

Hi,

I misunderstood the email as information of the subject of the commit message. I apologize for that.

Kindly find attached the patch with the commit message and the subject.

(See file attached:  0001-Fixed-non-pointer-type-compilation-error-in-aix-thread.c.patch)

Regards,
Aditya.
________________________________
From: Joel Brobecker <brobecker@adacore.com>
Sent: Tuesday, May 17, 2022 5:59 PM
To: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>
Cc: Aditya Vidyadhar Kamath via Gdb-patches <gdb-patches@sourceware.org>; Joel Brobecker <brobecker@adacore.com>; Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH] Resolve aix-thread.c compile errors

> Thank you so much for the feedback and the information on how to give
> a good description of commit message.
>
> Please find attached the patch now (See:
> 0001-Fixed-non-pointer-type-compilation-error-in-aix-thread.c.patch)

As far as I can tell, the patch is still missing a commit message
(other than the subject). Did you send the correct file?

> From 75d06292c20cbe6768843090cfcb706b519f842c Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Tue, 17 May 2022 07:03:34 -0500
> Subject: [PATCH] Fixed non-pointer type compilation error in aix-thread.c
>
> ---
>  gdb/aix-thread.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
> index 4e41cde6694..ecd8200b692 100644
> --- a/gdb/aix-thread.c
> +++ b/gdb/aix-thread.c
> @@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
>                gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
>              return PDC_FAILURE;
>            }
> -       symbols[i].addr = ms->value_address ();
> +       symbols[i].addr = ms.value_address ();
>        }
>        if (debug_aix_thread)
>        gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
> @@ -969,7 +969,7 @@ pd_enable (void)
>    ms = lookup_minimal_symbol (stub_name, NULL, NULL);
>    if (ms.minsym == NULL)
>      return;
> -  pd_brk_addr = ms->value_address ();
> +  pd_brk_addr = ms.value_address ();
>    if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
>      return;
>
> --
> 2.31.1
>


--
Joel

[-- Attachment #2: 0001-Fix-non-pointer-type-compilation-error-in-aix-thread.c.patch --]
[-- Type: application/octet-stream, Size: 1717 bytes --]

From e53aabd1daa58ec41efdaa6215c492ca01910570 Mon Sep 17 00:00:00 2001
From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
Date: Tue, 17 May 2022 07:51:08 -0500
Subject: [PATCH] Fix non-pointer type compilation error in aix-thread.c

In aix-thread.c we use ms-> value_address () to get the symbol address.

For a non pointer type variable we use non_pointer_var_name.var_name to access a variable.

For a pointer type variable we use pointer_var_name->var_name to access a variable.

Since the variable ms is a non pointer type that is accessing value_address function a compilation error,

[base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.

This can be seen while running gmake in the binutils folder while installing.

We must use ms.value_address () instead.
---
 gdb/aix-thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 4e41cde6694..ecd8200b692 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
 		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
 	      return PDC_FAILURE;
 	    }
-	  symbols[i].addr = ms->value_address ();
+	  symbols[i].addr = ms.value_address ();
 	}
       if (debug_aix_thread)
 	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
@@ -969,7 +969,7 @@ pd_enable (void)
   ms = lookup_minimal_symbol (stub_name, NULL, NULL);
   if (ms.minsym == NULL)
     return;
-  pd_brk_addr = ms->value_address ();
+  pd_brk_addr = ms.value_address ();
   if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
     return;
 
-- 
2.31.1

Re: [PATCH] Resolve aix-thread.c compile errors

[Joel Brobecker]

Thanks for sending an updated version of the commit.

We're trying to keep the commit message informative, but at the same
time, since most commit messages are fairly long, I think it's worth
trying to keep it as short while still giving all the necessary
information.

In this case...

> From e53aabd1daa58ec41efdaa6215c492ca01910570 Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Tue, 17 May 2022 07:51:08 -0500
> Subject: [PATCH] Fix non-pointer type compilation error in aix-thread.c
> 
> In aix-thread.c we use ms-> value_address () to get the symbol address.
> 

The text between here ...

> For a non pointer type variable we use non_pointer_var_name.var_name to access a variable.
> 
> For a pointer type variable we use pointer_var_name->var_name to access a variable.

... can be considered obvious and general knowledge, in my opinion,
and therefore can (should) be omitted, IMO.

> Since the variable ms is a non pointer type that is accessing value_address function a compilation error,
> 
> [base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.
> 
> This can be seen while running gmake in the binutils folder while installing.
> 
> We must use ms.value_address () instead.

Here's a suggestion for the commit message, inspired by the version
you sent, from subject to end of commit message:

<<
Fix non-pointer type compilation error in aix-thread.c

In aix-thread.c we use ms->value_address () to get the symbol address.
This triggers the following compiler error...

    base operand of '->'  has non-pointer type 'bound_minimal_symbol'

... because ms is not a pointer.

This commit fixes this error by using ms.value_address () instead.
>>

-- 
Joel

RE: [PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

[-- Attachment #1: Type: text/plain, Size: 2477 bytes --]

Hi,

Thank you so much for the feedback.

Please find attached the most recent patch with the suggested changes included.

(See file 0001-Fix-non-pointer-type-compilation-error-in-aix-thread.c.patch)

Thanks and regards,
Aditya.
________________________________
From: Joel Brobecker <brobecker@adacore.com>
Sent: Thursday, May 19, 2022 3:42 AM
To: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>; Aditya Vidyadhar Kamath via Gdb-patches <gdb-patches@sourceware.org>; Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH] Resolve aix-thread.c compile errors

Thanks for sending an updated version of the commit.

We're trying to keep the commit message informative, but at the same
time, since most commit messages are fairly long, I think it's worth
trying to keep it as short while still giving all the necessary
information.

In this case...

> From e53aabd1daa58ec41efdaa6215c492ca01910570 Mon Sep 17 00:00:00 2001
> From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
> Date: Tue, 17 May 2022 07:51:08 -0500
> Subject: [PATCH] Fix non-pointer type compilation error in aix-thread.c
>
> In aix-thread.c we use ms-> value_address () to get the symbol address.
>

The text between here ...

> For a non pointer type variable we use non_pointer_var_name.var_name to access a variable.
>
> For a pointer type variable we use pointer_var_name->var_name to access a variable.

... can be considered obvious and general knowledge, in my opinion,
and therefore can (should) be omitted, IMO.

> Since the variable ms is a non pointer type that is accessing value_address function a compilation error,
>
> [base operand of '->'  has non-pointer type 'bound_minimal_symbol' symbols[i].addr = ms-> value_address ()] is generated.
>
> This can be seen while running gmake in the binutils folder while installing.
>
> We must use ms.value_address () instead.

Here's a suggestion for the commit message, inspired by the version
you sent, from subject to end of commit message:

<<
Fix non-pointer type compilation error in aix-thread.c

In aix-thread.c we use ms->value_address () to get the symbol address.
This triggers the following compiler error...

    base operand of '->'  has non-pointer type 'bound_minimal_symbol'

... because ms is not a pointer.

This commit fixes this error by using ms.value_address () instead.
>>

--
Joel

[-- Attachment #2: 0001-Fix-non-pointer-type-compilation-error-in-aix-thread.c.patch --]
[-- Type: application/octet-stream, Size: 1408 bytes --]

From 37ad10355505b294df0e54467684792626604363 Mon Sep 17 00:00:00 2001
From: "aditya@ibm" <aditya.vidyadhar.kamath@ibm.com>
Date: Thu, 19 May 2022 08:42:44 -0500
Subject: [PATCH] Fix non-pointer type compilation error in aix-thread.c

In aix-thread.c we use ms->value_address () to get the symbol address.
This triggers the following compiler error...

     base operand of '->'  has non-pointer type 'bound_minimal_symbol'

... because ms is not a pointer.

This commit fixes this error by using ms.value_address () instead.
---
 gdb/aix-thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/aix-thread.c b/gdb/aix-thread.c
index 4e41cde6694..ecd8200b692 100644
--- a/gdb/aix-thread.c
+++ b/gdb/aix-thread.c
@@ -360,7 +360,7 @@ pdc_symbol_addrs (pthdb_user_t user, pthdb_symbol_t *symbols, int count)
 		gdb_printf (gdb_stdlog, " returning PDC_FAILURE\n");
 	      return PDC_FAILURE;
 	    }
-	  symbols[i].addr = ms->value_address ();
+	  symbols[i].addr = ms.value_address ();
 	}
       if (debug_aix_thread)
 	gdb_printf (gdb_stdlog, "  symbols[%d].addr = %s\n",
@@ -969,7 +969,7 @@ pd_enable (void)
   ms = lookup_minimal_symbol (stub_name, NULL, NULL);
   if (ms.minsym == NULL)
     return;
-  pd_brk_addr = ms->value_address ();
+  pd_brk_addr = ms.value_address ();
   if (!create_thread_event_breakpoint (target_gdbarch (), pd_brk_addr))
     return;
 
-- 
2.31.1

Re: [PATCH] Resolve aix-thread.c compile errors

[Joel Brobecker]

> Thank you so much for the feedback.
> 
> Please find attached the most recent patch with the suggested changes
> included.

Thank you. This all looks good to me, now. Can you push the change?

-- 
Joel

RE: [PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

Hi ,

I am getting an error message that I do not have the permission to push the changes. Is there a way you can help me with it??

Thanks and regards,
Aditya
________________________________
From: Joel Brobecker <brobecker@adacore.com>
Sent: Friday, May 20, 2022 12:03 AM
To: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>; Aditya Vidyadhar Kamath via Gdb-patches <gdb-patches@sourceware.org>; Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH] Resolve aix-thread.c compile errors

> Thank you so much for the feedback.
>
> Please find attached the most recent patch with the suggested changes
> included.

Thank you. This all looks good to me, now. Can you push the change?

--
Joel

Re: [PATCH] Resolve aix-thread.c compile errors

[Joel Brobecker]

> I am getting an error message that I do not have the permission to
> push the changes. Is there a way you can help me with it??

No problem. I pushed it for you (after having fied the author name
and author email address -- you might want to fix that in your git
config).

The author name & email was:

    Author: aditya@ibm <aditya@ibm>

I changed it to:

    Author: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>

-- 
Joel

RE: [PATCH] Resolve aix-thread.c compile errors

[Aditya Vidyadhar Kamath]

Thank you so much
________________________________
From: Joel Brobecker <brobecker@adacore.com>
Sent: Friday, May 20, 2022 7:48 PM
To: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>
Cc: Joel Brobecker <brobecker@adacore.com>; Aditya Vidyadhar Kamath via Gdb-patches <gdb-patches@sourceware.org>; Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: [PATCH] Resolve aix-thread.c compile errors

> I am getting an error message that I do not have the permission to
> push the changes. Is there a way you can help me with it??

No problem. I pushed it for you (after having fied the author name
and author email address -- you might want to fix that in your git
config).

The author name & email was:

    Author: aditya@ibm <aditya@ibm>

I changed it to:

    Author: Aditya Vidyadhar Kamath <ADITYA.VIDYADHAR.KAMATH@ibm.com>

--
Joel