RE: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point

["George, Jini Susan" <JiniSusan.George@amd.com>]

[AMD Official Use Only]

Thank you, Nils, for making the changes. The code part of the patch (I did not look at the tests) LGTM except for one nit.

In dwarf2_get_pc_bounds_entry_point(),
...
the highpc from it's enveloping subprogram and get the lowpc from
...

"it's" needs to be changed to "its"

Thanks,
Jini.

>>-----Original Message-----
>>From: Nils-Christian Kempke <nils-christian.kempke@intel.com>
>>Sent: Thursday, April 14, 2022 3:11 PM
>>To: gdb-patches@sourceware.org
>>Cc: George, Jini Susan <JiniSusan.George@amd.com>; kevinb@redhat.com;
>>Nils-Christian Kempke <nils-christian.kempke@intel.com>
>>Subject: [PATCH v2 0/1] Fortran entry and DW_TAG_entry_point
>>
>>[CAUTION: External Email]
>>
>>Hi,
>>
>>please find attached v2 of this series.  It introduced the handling of
>>DW_TAG_entry_point to GDB.
>>
>>I want to emphasize again - between gfortran, ifort, and ifx only ifort seems to
>>currently emit this tag.  So the attached test only really works when using ifort.
>>After a comment from Kevin I now added a gdb.dwarf2 test for GDB's handling
>>of this tag such that it can be tested without the availablity of a compiler
>>emitting it.
>>
>>V1 can be found here, it was originally submitted as [RFC]:
>>
>>https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsource
>>ware.org%2Fpipermail%2Fgdb-patches%2F2022-
>>March%2F186900.html&amp;data=04%7C01%7Cjinisusan.george%40amd.com
>>%7Ca08c7e55cfad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e
>>183d%7C0%7C0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJ
>>WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C
>>3000&amp;sdata=hM3fCyuREy4Aj8XBeNaAb4HL%2B8mkBQAfuyAnpK5trCs%3D
>>&amp;reserved=0
>>
>>Changes since v1:
>>
>>        * I rebased to master and removed the partial symbol stuff from
>>        this patch since this part has been reworked recently.  I hope I
>>        adapted to the changes correctly.
>>        * I added the handling of a DW_TAG_entry_points prefix in
>>        'determine_prefix' (after Jini pointing out a bug here).
>>        * I removed an if that checked for fortran as the cu's language
>>        in new_symbol and made the handling of DW_TAG_entry_point
>>        language agnostic.
>>        * I changed the return type of 'dwarf2_get_pc_bounds_entry_point'
>>        to also return PC_BOUNDS_RANGES if the parent die returns these.
>>        * I added a gdb.dwarf2 test to be able to check this test even
>>        when one does not have ifort at hand.  The new test compiles
>>        some .c helper with some labels and uses that to put some
>>        entry point dwarf on top.  It then checks whether we can break
>>        at the entry points.
>>
>>Cheers!
>>Nils
>>
>>
>>Nils-Christian Kempke (1):
>>  dwarf, fortran: add support for DW_TAG_entry_point
>>
>> gdb/dwarf2/abbrev.c                           |   1 +
>> gdb/dwarf2/read.c                             |  72 ++++++++-
>> gdb/testsuite/gdb.dwarf2/dw2-entry-points.c   |  39 +++++
>> gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp | 149 ++++++++++++++++++
>> gdb/testsuite/gdb.fortran/entry-point.exp     |  84 ++++++++++
>> gdb/testsuite/gdb.fortran/entry-point.f90     |  67 ++++++++
>> 6 files changed, 411 insertions(+), 1 deletion(-)  create mode 100644
>>gdb/testsuite/gdb.dwarf2/dw2-entry-points.c
>> create mode 100644 gdb/testsuite/gdb.dwarf2/dw2-entry-points.exp
>> create mode 100644 gdb/testsuite/gdb.fortran/entry-point.exp
>> create mode 100644 gdb/testsuite/gdb.fortran/entry-point.f90
>>
>>--
>>2.25.1
>>
>>Intel Deutschland GmbH
>>Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>Tel: +49 89 99 8853-0,
>>https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.int
>>el.de%2F&amp;data=04%7C01%7Cjinisusan.george%40amd.com%7Ca08c7e55c
>>fad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C
>>0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA
>>wMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sda
>>ta=de639g%2BROumUaBh9WP3GXaakd%2BW7VuTW%2F6YDJA9c5N4%3D&am
>>p;reserved=0
>><https://nam11.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.in
>>tel.de%2F&amp;data=04%7C01%7Cjinisusan.george%40amd.com%7Ca08c7e55
>>cfad4480c8cc08da1dfaf41f%7C3dd8961fe4884e608e11a82d994e183d%7C0%7
>>C0%7C637855260922818318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLj
>>AwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sd
>>ata=de639g%2BROumUaBh9WP3GXaakd%2BW7VuTW%2F6YDJA9c5N4%3D&a
>>mp;reserved=0>
>>Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
>>Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich
>>Commercial Register: Amtsgericht Muenchen HRB 186928