From: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>
To: Tom Tromey <tom@tromey.com>,
Nils-Christian Kempke via Gdb-patches
<gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer types.
Date: Mon, 31 Jan 2022 08:15:50 +0000 [thread overview]
Message-ID: <BYAPR11MB3288D6086DA1E7BB7A5BF802B8259@BYAPR11MB3288.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87mtjf3e85.fsf@tromey.com>
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Friday, January 28, 2022 7:30 PM
> To: Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> Subject: Re: [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer
> types.
>
> >> + if (top_level &&
> >> + (type->code () == TYPE_CODE_REF || type->code () ==
> TYPE_CODE_PTR))
>
> In the gdb style, operators like "&&" go on the start of the
> continuation line.
>
> Tom
Hi Tom,
Thanks for looking at this. Yes - that's indeed correct I'll change
it and keep it in mind for a possible v2 of this patch. Did you
have a chance to look into this more deeply/have any more comments
on this patch?
Cheers,
Nils
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-01-31 8:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-18 13:26 [PATCH 0/2] Resolve dynamic types for pointers Nils-Christian Kempke
2022-01-18 13:26 ` [PATCH 1/2] gdb/types: Resolve dynamic properties of pointer types Nils-Christian Kempke
2022-01-28 18:30 ` Tom Tromey
2022-01-31 8:15 ` Kempke, Nils-Christian [this message]
2022-01-18 13:26 ` [PATCH 2/2] gdb: Resolve dynamic target types of pointers Nils-Christian Kempke
2022-02-10 19:47 ` Tom Tromey
2022-04-14 10:22 ` Kempke, Nils-Christian
2022-04-15 16:14 ` Tom Tromey
2022-04-19 6:59 ` Kempke, Nils-Christian
2022-05-13 14:45 ` Kempke, Nils-Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3288D6086DA1E7BB7A5BF802B8259@BYAPR11MB3288.namprd11.prod.outlook.com \
--to=nils-christian.kempke@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).