public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@gmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: apinski--- via Gdb-patches <gdb-patches@sourceware.org>,
	binutils@sourceware.org,  gcc-patches@gcc.gnu.org,
	apinski@marvell.com,  Jeff Law <jeffreyalaw@gmail.com>
Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb
Date: Tue, 20 Dec 2022 19:45:44 -0800	[thread overview]
Message-ID: <CA+=Sn1=v29jvdw2qK82pc7r0=02TJ_05OcT1WbUpn=pYswcTmQ@mail.gmail.com> (raw)
In-Reply-To: <877cyllx53.fsf@tromey.com>

On Tue, Dec 20, 2022 at 10:59 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Andrew" == apinski--- via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> From: Andrew Pinski <apinski@marvell.com>
> Andrew> This patch uses the toplevel configure parts for GMP/MPFR for
> Andrew> gdb. The only thing is that gdb now requires MPFR for building.
> Andrew> Before it was a recommended but not required library.
> Andrew> Also this allows building of GMP and MPFR with the toplevel
> Andrew> directory just like how it is done for GCC.
> Andrew> We now error out in the toplevel configure of the version
> Andrew> of GMP and MPFR that is wrong.
>
> Andrew> OK after GDB 13 branches? Build gdb 3 ways:
> Andrew> with GMP and MPFR in the toplevel (static library used at that point for both)
> Andrew> With only MPFR in the toplevel (GMP distro library used and MPFR built from source)
> Andrew> With neither GMP and MPFR in the toplevel (distro libraries used)
>
> I think it's fine to move forward with this now.
> Thank you again for doing this.

Just to double check this is an approval?

Jeff,
  Just to double check this is still ok for gcc repo even if we are in stage 3?

Thanks,
Andrew Pinski


>
> Tom

  reply	other threads:[~2022-12-21  3:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-10 19:05 apinski
2022-11-16  3:59 ` Jeff Law
2022-11-16 16:01   ` Tom Tromey
2022-11-16 18:50     ` Jeff Law
2022-12-20 18:59 ` Tom Tromey
2022-12-21  3:45   ` Andrew Pinski [this message]
2022-12-21 14:56     ` Jeff Law
2022-12-21 15:03     ` Tom Tromey
2023-01-03 10:52       ` Clément Chigot
2023-01-03 11:51         ` Nick Clifton
2023-01-03 11:52         ` Andrew Pinski
2023-01-03 13:12           ` Clément Chigot
2023-08-10 12:47 ` Matthias Klose
2023-08-10 19:00   ` Arsen Arsenović
  -- strict thread matches above, loose matches on Subject: below --
2022-11-10 19:03 apinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+=Sn1=v29jvdw2qK82pc7r0=02TJ_05OcT1WbUpn=pYswcTmQ@mail.gmail.com' \
    --to=pinskia@gmail.com \
    --cc=apinski@marvell.com \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).