From: Gareth Rees <grees@undo.io>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4] [PR mi/29554] New PRINT-VALUES option '--scalar-values'.
Date: Thu, 20 Oct 2022 18:58:13 +0100 [thread overview]
Message-ID: <CAA8DSpEjtUJ23wXdrvpUu+zxsup8OMR_OVgGRxLrc63tdJZo+w@mail.gmail.com> (raw)
In-Reply-To: <87fsftateu.fsf@redhat.com>
Thank you for the thorough review. I implemented all your suggestions,
and have attempted to add tests covering all the behaviour of the new
'--scalar-values' option. The revised patch is v5, posted separately.
Andrew Burgess wrote:
> > +/* Print VAL according to VALUES? */
> > +
> > +static bool
> > +print_value_p (struct value *val, enum print_values values)
> > +{
> > + switch (values)
> > + {
> > + default:
> > + case PRINT_NO_VALUES:
> > + return false;
> > + case PRINT_ALL_VALUES:
> > + return true;
> > + case PRINT_SIMPLE_VALUES:
> > + return mi_simple_values_type_p (value_type (val));
> > + case PRINT_SCALAR_VALUES:
> > + return val_print_scalar_type_p (value_type (val));
> > + }
> > +}
>
> I think you should probably fold together this print_value_p and
> print_symbol_p in mi-cmd-stack.c. Maybe create an mi_print_type_p
> somewhere, which can contain the core switch table?
I have implemented this suggestion. Note that a consequence is that in
the PRINT_NO_VALUES and PRINT_ALL_VALUES cases, we now incur a call to
value_type(val) or sym->type() when previously we just returned false
or true respectively. I think this is probably worth it, in order to
reduce the amount of duplicated code, but just want to highlight the
small change in behaviour here.
next prev parent reply other threads:[~2022-10-20 17:58 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 7:18 [PATCH] [gdb/mi] Don't treat references to compound values as "simple" Gareth Rees
2022-09-08 10:27 ` Andrew Burgess
2022-09-08 11:02 ` [PATCH v2] " Gareth Rees
2022-09-08 13:30 ` Eli Zaretskii
2022-09-08 13:58 ` Gareth Rees
2022-09-08 14:07 ` Eli Zaretskii
2022-09-09 8:01 ` [PATCH v3] [PR mi/29554] New PRINT-VALUES option '--scalar-values' Gareth Rees
2022-09-15 9:06 ` [PING] " Gareth Rees
2022-09-25 8:15 ` Gareth Rees
2022-09-25 8:25 ` Eli Zaretskii
2022-09-25 9:00 ` Gareth Rees
2022-09-25 10:16 ` Eli Zaretskii
2022-09-26 12:48 ` Gareth Rees
2022-09-25 10:16 ` Eli Zaretskii
2022-09-26 12:46 ` [PATCH v4] " Gareth Rees
2022-10-04 9:08 ` [PING] " Gareth Rees
2022-10-18 11:59 ` Gareth Rees
2022-10-12 16:38 ` Andrew Burgess
2022-10-20 17:47 ` [PATCH v5] " Gareth Rees
2022-10-20 18:00 ` Eli Zaretskii
2022-11-03 16:20 ` [PING] " Gareth Rees
2022-11-14 9:25 ` Gareth Rees
2022-12-01 13:41 ` Gareth Rees
2022-12-14 8:50 ` Gareth Rees
2023-02-01 10:00 ` Gareth Rees
2023-02-16 10:08 ` Gareth Rees
2023-03-06 9:52 ` Gareth Rees
2023-03-08 12:35 ` Andrew Burgess
2023-03-10 11:04 ` Gareth Rees
2023-03-10 12:05 ` Eli Zaretskii
2023-03-10 12:58 ` Gareth Rees
2023-03-13 17:17 ` Andrew Burgess
2023-03-16 12:28 ` Gareth Rees
2023-03-11 11:58 ` Gareth Rees
2023-04-11 13:15 ` Pedro Alves
2023-03-11 11:49 ` [PATCH v6] [gdb/mi] Don't treat references to compound values as "simple" Gareth Rees
2023-03-21 9:50 ` [PING] " Gareth Rees
2023-03-26 9:56 ` Gareth Rees
2023-04-03 9:22 ` Gareth Rees
2023-05-04 15:08 ` Tom Tromey
2023-04-18 9:23 ` Gareth Rees
2023-04-24 9:53 ` Gareth Rees
2023-05-02 9:13 ` Gareth Rees
2023-03-27 14:34 ` Tom Tromey
2023-03-29 9:14 ` Gareth Rees
2023-04-06 17:18 ` Gareth Rees
2022-10-20 17:58 ` Gareth Rees [this message]
2022-09-09 8:04 ` [PATCH v2] " Gareth Rees
2022-09-08 11:09 ` [PATCH] " Gareth Rees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8DSpEjtUJ23wXdrvpUu+zxsup8OMR_OVgGRxLrc63tdJZo+w@mail.gmail.com \
--to=grees@undo.io \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).