From: Roland McGrath <mcgrathr@google.com>
To: Tom Tromey <tom@tromey.com>
Cc: Roland McGrath via Gdb-patches <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>
Subject: Re: [PATCH users/roland/safe-ctype] Uniformly put `#include "safe-ctype.h"` last among #include directives
Date: Mon, 24 Apr 2023 10:40:41 -0700 [thread overview]
Message-ID: <CAB=4xhrE+1A0uSwY3sa5qVp44vWgav33mfR3R9=65EfEE0L2UQ@mail.gmail.com> (raw)
In-Reply-To: <87ildlxkkx.fsf@tromey.com>
[-- Attachment #1: Type: text/plain, Size: 623 bytes --]
That seems easier to maintain without breakage over the long term than my
version. Can we get that landed forthwith?
Thanks,
Roland
On Mon, Apr 24, 2023 at 10:21 AM Tom Tromey <tom@tromey.com> wrote:
> >>>>> "Roland" == Roland McGrath via Gdb-patches <
> gdb-patches@sourceware.org> writes:
>
> Roland> I didn't touch anything in the libiberty subdirectory since AIUI
> Roland> that's still copied from the gcc repository.
>
> There's also this patch to fix it differently:
>
> https://sourceware.org/pipermail/gdb-patches/2023-April/198954.html
>
> which isolates the damage to gdb.
>
> Tom
>
next prev parent reply other threads:[~2023-04-24 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 0:55 Roland McGrath
2023-04-24 3:03 ` Alan Modra
2023-04-24 17:21 ` Tom Tromey
2023-04-24 17:40 ` Roland McGrath [this message]
2023-04-29 7:36 ` Roland McGrath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB=4xhrE+1A0uSwY3sa5qVp44vWgav33mfR3R9=65EfEE0L2UQ@mail.gmail.com' \
--to=mcgrathr@google.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).